fix: repair failing tests and implement missing utility functionality#238
Open
stooit wants to merge 1 commit into
Open
fix: repair failing tests and implement missing utility functionality#238stooit wants to merge 1 commit into
stooit wants to merge 1 commit into
Conversation
- calculator: throw on division by zero instead of returning Infinity - date-utils: fix off-by-one in formatRelative (round hours-to-days) - string-utils: implement wordCount consecutive-space handling and word-boundary truncate with ellipsis-aware budget - task-manager: implement remove, update, and sortBy methods - validator: accept long TLDs in isEmail and ports in isUrl
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all 16 previously-failing tests across the utility library and implements missing functionality. All 60 tests now pass (0 fail), with no changes to test files and no new dependencies.
Changes by file
dividenow throwsError("Division by zero")instead of returningInfinity.formatRelative: usesMath.roundon hours→days so 36h ago reads "2 days ago". Removed stale BUG comment.wordCounthandling of multiple consecutive spaces; implemented word-boundarytruncatewith an ellipsis-aware length budget (output always ≤ maxLength, including small maxLength).remove,update, andsortBy(priority + createdAt) methods.isEmailaccepts long TLDs (e.g..museum);isUrlaccepts URLs with ports (e.g.http://localhost:3000).Verification
bun test→ 60 pass / 0 fail.truncateedge case (maxLength < ellipsis length) was hardened.Assumptions
formatRelativeuses rounding (not floor) per the 36-hour test expectation.dividethrows only on exactb === 0(strict).sortBypriority order is high > medium > low;createdAtsorts oldest first, matching the tests.Constraints honoured