fix: repair all failing utility functions#239
Open
stooit wants to merge 1 commit into
Open
Conversation
- calculator: divide now throws on division by zero instead of returning Infinity - date-utils: formatRelative uses Math.round so 36h rounds to 2 days - string-utils: implement truncate (word boundary, ellipsis in maxLength) and fix wordCount for consecutive spaces - task-manager: implement remove, update, and sortBy methods - validator: fix isEmail long-TLD and isUrl port handling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all 16 failing tests across the utility library. All 60 tests now pass (0 fail).
Changes
dividenow throwsError("Division by zero")instead of returningInfinity.formatRelativeusesMath.round(wasMath.floor) so 36 hours ago rounds to "2 days ago".truncate(returns unchanged within limit, truncates at word boundary, ellipsis counts towardmaxLength, handles strings shorter than the ellipsis); fixedwordCountto collapse consecutive spaces.remove(false for unknown id),update(title & priority, false for unknown id), andsortBy(priority high>medium>low, createdAt oldest first).isEmailfor long TLDs andisUrlfor URLs with a port (e.g.http://localhost:3000).Verification
bun test-> 60 pass, 0 fail.Assumptions & notes
isEmail/isUrlpatterns remain permissive for some structurally-odd inputs not covered by tests. Tightening them was deliberately left out to avoid regressing passing tests and to respect the "fix only what the tests require" constraint.