fix(docs): make Vale style check blocking#180
Merged
Merged
Conversation
check:style ran run-vale.mjs with --no-exit, so style errors (including the error-level EmDash rule) never failed CI; banned punctuation shipped in past PRs with green checks. Vale is clean on main (0 errors in 42 files), and with this change an injected violation exits 1. Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Drop
--no-exitfrom the docs-sitecheck:stylescript so Vale failures fail the check.Why
scripts/run-vale.mjs --no-exitreports style errors but always exits 0, so the error-level style rules (em dashes, banned words) have been advisory in CI. Recent doc PRs shipped banned punctuation with green checks; making the gate real prevents the next occurrence.Evidence
npm run check:stylereports 0 errors, 0 warnings, 0 suggestions in 42 files, exit 0.No content changes; one line in
docs/site/package.json.