ci(maestro): bump WalletConnect/actions for redesigned /collect IC form#556
Draft
ignaciosantise wants to merge 1 commit into
Draft
ci(maestro): bump WalletConnect/actions for redesigned /collect IC form#556ignaciosantise wants to merge 1 commit into
ignaciosantise wants to merge 1 commit into
Conversation
…llect IC form Provisionally pinned to the branch tip of WalletConnect/actions#106 (KYC /collect inline IC form redesign). Re-pin to the merged-master SHA before merging, and only after buyer-experience #914 is deployed. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Claude finished @ignaciosantise's task in 1m 9s —— View job Review
✅ No issues found The diff bumps three pinned SHA refs ( The provisional-SHA situation (branch tip vs. merged-master) is correctly called out in inline comments on lines 433, 436, and 605 and is the central sequencing concern in the PR description. No additional flags from the breaking-changes or data-classification checks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump
WalletConnect/actionsmaestro refs for the redesigned/collectIC formWalletConnect/buyer-experiencePR #914 redesigns the hosted KYC webview (the/collectroute the sample wallet opens in a WebView). The native Maestropayflows drive that webview by visible text/testIDs, so they were updated in WalletConnect/actions#106 (submit button "Add" → "Confirm", "Confirm your details" dialog removed, inlineconsent-checkbox).This PR bumps every pinned
WalletConnect/actions/maestro/*ref (pay-tests / setup / permit2-reset) to the new flow commit so the KYC flows match the redesigned form.The ref is pinned to the branch tip of WalletConnect/actions#106 (
a6436df), not a merged-master SHA. Before this PR leaves draft:master— then re-pin to the merged-master SHA (git rev-parse origin/master)./collectwebview loads (prod/staging). The new steps fail against the old form and vice-versa — there is an unavoidable mutually-exclusive window; coordinate so apay-tagged Maestro run doesn't start mid-window.Sequencing
/collectform is live.payMaestro run to confirm the KYC flows pass.🤖 Generated with Claude Code