ci: run tmt e2e tests on GitHub-hosted runners with nested KVM by coiby · Pull Request #29 · rhkdump/kernel-auto-bisect

coiby · 2026-06-14T03:53:42Z

Provision two Fedora VMs per plan via testcloud/libvirt and runs the
bisection end-to-end. Uses matrix strategy for parallel execution
across all 4 plans (ssh, ssh_src, ssh_auto, criu).
8-hour timeout per plan, fail-fast: false.
Uploads /var/tmp/tmt/run* for debugging.

gemini-code-assist

Code Review

This pull request refactors the test scripts to standardize log file paths using a dynamic $XTRACE_LOG variable and updates the target kernel version in the auto-bisect test. However, using the local $XTRACE_LOG path inside a remote SSH command in tests/kab_criu/test.sh will fail because the directory structure does not exist on the remote host; you should use a remote log path and then copy it back via scp. Additionally, several variables like $SERVER_SSH_KEY and $KAB_SCRIPT should be double-quoted to prevent word splitting and globbing issues.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

gemini-code-assist · 2026-06-14T03:54:37Z

+XTRACE_LOG=$TMT_PLAN_DATA/test.log
 # 2. Start kab.sh on Target if not already running and no checkpoint exists
 if ! ssh_cmd "pgrep -f $KAB_SCRIPT" >/dev/null 2>&1 && ! ssh_cmd "ls /var/local/kernel-auto-bisect/dump/core-*.img" >/dev/null 2>&1; then
 	echo "Starting kab.sh..."
-	ssh_cmd "setsid bash -x $KAB_SCRIPT </dev/null &>/root/test.log &"
+	ssh_cmd "setsid bash -x $KAB_SCRIPT </dev/null &>$XTRACE_LOG &"
 fi


The $XTRACE_LOG variable contains a local path on the client (e.g., /var/tmp/tmt/...). Since this command is executed on the remote target host via ssh_cmd, the remote shell will attempt to redirect output to this local path. Because the directory structure does not exist on the remote host, the redirection will fail, preventing kab.sh from starting or logging correctly.

Instead, use a standard remote path (like /root/test.log) for execution on the target host, and then copy it back to the local $XTRACE_LOG path.

Suggested change

XTRACE_LOG=$TMT_PLAN_DATA/test.log

# 2. Start kab.sh on Target if not already running and no checkpoint exists

if ! ssh_cmd "pgrep -f $KAB_SCRIPT" >/dev/null 2>&1 && ! ssh_cmd "ls /var/local/kernel-auto-bisect/dump/core-*.img" >/dev/null 2>&1; then

echo "Starting kab.sh..."

ssh_cmd "setsid bash -x $KAB_SCRIPT </dev/null &>/root/test.log &"

ssh_cmd "setsid bash -x $KAB_SCRIPT </dev/null &>$XTRACE_LOG &"

fi

REMOTE_LOG=/root/test.log

XTRACE_LOG=$TMT_PLAN_DATA/test.log

# 2. Start kab.sh on Target if not already running and no checkpoint exists

if ! ssh_cmd "pgrep -f $KAB_SCRIPT" >/dev/null 2>&1 && ! ssh_cmd "ls /var/local/kernel-auto-bisect/dump/core-*.img" >/dev/null 2>&1; then

echo "Starting kab.sh..."

ssh_cmd "setsid bash -x $KAB_SCRIPT </dev/null &>$REMOTE_LOG &"

fi

gemini-code-assist · 2026-06-14T03:54:38Z

 	wait_time=$((wait_time + 10))
 done

+scp "${ssh_opts[@]}" "${TARGET_HOST}:${XTRACE_LOG}" "$XTRACE_LOG"


Update the source path of the scp command to use the remote log path ($REMOTE_LOG) instead of the local $XTRACE_LOG path.

Suggested change

scp "${ssh_opts[@]}" "${TARGET_HOST}:${XTRACE_LOG}" "$XTRACE_LOG"

scp "${ssh_opts[@]}" "${TARGET_HOST}:${REMOTE_LOG}" "$XTRACE_LOG"

gemini-code-assist · 2026-06-14T03:54:38Z

+if [[ -f "$SERVER_SSH_KEY" ]]; then
+	ssh_opts+=(-o IdentitiesOnly=yes -i $SERVER_SSH_KEY)
+fi


The variable $SERVER_SSH_KEY should be double-quoted to prevent word splitting and globbing if the path contains spaces or special characters.

Suggested change

if [[ -f "$SERVER_SSH_KEY" ]]; then

ssh_opts+=(-o IdentitiesOnly=yes -i $SERVER_SSH_KEY)

fi

if [[ -f "$SERVER_SSH_KEY" ]]; then

ssh_opts+=(-o IdentitiesOnly=yes -i "$SERVER_SSH_KEY")

fi

gemini-code-assist · 2026-06-14T03:54:38Z

+	XTRACE_LOG=$TMT_PLAN_DATA/test.log
+	bash -x $KAB_SCRIPT </dev/null &>"$XTRACE_LOG"


Quote the $KAB_SCRIPT variable to prevent potential word splitting or globbing issues.

Suggested change

XTRACE_LOG=$TMT_PLAN_DATA/test.log

bash -x $KAB_SCRIPT </dev/null &>"$XTRACE_LOG"

XTRACE_LOG=$TMT_PLAN_DATA/test.log

bash -x "$KAB_SCRIPT" </dev/null &>"$XTRACE_LOG"

gemini-code-assist · 2026-06-14T03:54:38Z

+	XTRACE_LOG=$TMT_PLAN_DATA/test.log
+	bash -x $KAB_SCRIPT </dev/null &>"$XTRACE_LOG"


Quote the $KAB_SCRIPT variable to prevent potential word splitting or globbing issues.

Suggested change

XTRACE_LOG=$TMT_PLAN_DATA/test.log

bash -x $KAB_SCRIPT </dev/null &>"$XTRACE_LOG"

XTRACE_LOG=$TMT_PLAN_DATA/test.log

bash -x "$KAB_SCRIPT" </dev/null &>"$XTRACE_LOG"

When pre-commit runs during git commit --amend in a worktree, Git exports repository-local variables such as GIT_DIR and GIT_WORK_TREE into the hook environment. ShellSpec tests that create nested temporary repositories then inherit those variables, so git init/config/commit can operate on the outer repository instead of the test repo. Load a shared ShellSpec helper and unset Git's local environment variables before specs run, keeping nested test repositories isolated from the invoking repository.

- Provision two Fedora VMs per plan via testcloud/libvirt and runs the bisection end-to-end. Uses matrix strategy for parallel execution across all 4 plans (ssh, ssh_src, ssh_auto, criu). 8-hour timeout per plan, fail-fast: false. - Uploads /var/tmp/tmt/run* for debugging.

Fedora 44 Cloud /boot uses Btrfs subvolume for /boot [1]. Running the e2e tests can encounter issues like [2][3]. So use Fedora 43 to bypass these issues. [1] https://fedoraproject.org/wiki/Changes/BtrfsBootForCloud [2] https://bugzilla.redhat.com/show_bug.cgi?id=2483604 [3] rhkdump/kdump-utils#155

6.19.{3..5}-300.fc44 were deleted. This can lead the failure of kab_ssh_auto test. Use 6.19.2-300.fc44 instead.

kernel-auto-bisect/main.log is the what we care most to know the progress. For criu e2e test, kab.sh will be checkpointed by CRIU and then the system will get rebooted. To continuously display main.log, we append remote main.log to local file and use "tail -f" to show the content.

kernel-auto-bisect/main.log is the what we care most to know the progress. So use "tmt run execute -vvv" so the main logs can be displayed.

tmt is natively supported on Fedora. By using Fedora container, some benefits includes bypassing issue [1]. [1] teemtee/testcloud#30

gemini-code-assist Bot reviewed Jun 14, 2026

View reviewed changes

coiby force-pushed the github_action_tmt branch 3 times, most recently from 0576b86 to 851332f Compare June 17, 2026 09:55

coiby added 7 commits June 20, 2026 17:50

Fix ShellSpec stderr warning on yes command when run in git hook

c61f62f

ci: 6.19.5-300.fc44 was deleted

d3cf1fc

6.19.{3..5}-300.fc44 were deleted. This can lead the failure of kab_ssh_auto test. Use 6.19.2-300.fc44 instead.

ci: Copy xtrace logs to TMT_PLAN_DATA for debug

0bb2002

tests: include tmt.sh in test_lib.sh

9ec2318

coiby force-pushed the github_action_tmt branch 3 times, most recently from 10c736d to f4103c9 Compare June 21, 2026 03:57

coiby added 3 commits July 3, 2026 18:33

ci: Only output kernel-auto-bisect/main.log for other e2e tests

994d586

kernel-auto-bisect/main.log is the what we care most to know the progress. So use "tmt run execute -vvv" so the main logs can be displayed.

ci: Run e2e tests on Fedora container

13ec030

tmt is natively supported on Fedora. By using Fedora container, some benefits includes bypassing issue [1]. [1] teemtee/testcloud#30

coiby force-pushed the github_action_tmt branch from f4103c9 to 13ec030 Compare July 3, 2026 10:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

ci: run tmt e2e tests on GitHub-hosted runners with nested KVM#29

ci: run tmt e2e tests on GitHub-hosted runners with nested KVM#29
coiby wants to merge 10 commits into
rhkdump:mainfrom
coiby:github_action_tmt

coiby commented Jun 14, 2026

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

gemini-code-assist Bot Jun 14, 2026

Uh oh!

gemini-code-assist Bot Jun 14, 2026

Uh oh!

gemini-code-assist Bot Jun 14, 2026

Uh oh!

gemini-code-assist Bot Jun 14, 2026

Uh oh!

gemini-code-assist Bot Jun 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

	scp "${ssh_opts[@]}" "${TARGET_HOST}:${XTRACE_LOG}" "$XTRACE_LOG"
	scp "${ssh_opts[@]}" "${TARGET_HOST}:${REMOTE_LOG}" "$XTRACE_LOG"

		XTRACE_LOG=$TMT_PLAN_DATA/test.log
		bash -x $KAB_SCRIPT </dev/null &>"$XTRACE_LOG"

Uh oh!

Conversation

coiby commented Jun 14, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist Bot Jun 14, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Jun 14, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Jun 14, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Jun 14, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Jun 14, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant