Skip to content

test_rclcpp :- Add local and async set_parameters_atomically tests#595

Open
Aaravanand00 wants to merge 1 commit into
ros2:rollingfrom
Aaravanand00:fix-issue-282-atomic-param-tests
Open

test_rclcpp :- Add local and async set_parameters_atomically tests#595
Aaravanand00 wants to merge 1 commit into
ros2:rollingfrom
Aaravanand00:fix-issue-282-atomic-param-tests

Conversation

@Aaravanand00

Copy link
Copy Markdown

Description

This PR adds the missing tests for set_parameters_atomically to the test_rclcpp suite. It includes both local parameter assignment and remote asynchronous parameter assignment tests.

Changes included:

  • Added test_set_parameters_atomically_async helper function to parameter_fixtures.hpp.
  • Added local_set_parameters_atomically test case in test_local_parameters.cpp to verify atomic parameter assignment on a local node.
  • Added asynchronous set_parameters_atomically tests to test_remote_parameters.cpp to verify remote atomic assignment (both for regular parameters and strict parameters_must_declare nodes).

Fixes #282

Is this user-facing behavior change?

Did you use Generative AI?

Yes, this pull request was generated with the assistance of Antigravity (a generative AI assistant ) to implement the test logic and boilerplate.

Additional Information

All newly added integration tests successfully pass locally against the Jazzy distribution in a WSL2 Ubuntu 24.04 environment.

@mergify

mergify Bot commented Jun 27, 2026

Copy link
Copy Markdown

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@Aaravanand00 Aaravanand00 force-pushed the fix-issue-282-atomic-param-tests branch 2 times, most recently from e3e91bf to 1c21c36 Compare June 27, 2026 19:38

@fujitatomoya fujitatomoya left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the original issue is almost 8 years ago, but this test case is still missing. lgtm. thanks for the contribution.

@fujitatomoya fujitatomoya left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, can you target this against rolling branch? that is where we develop as mainline.

@Aaravanand00 Aaravanand00 force-pushed the fix-issue-282-atomic-param-tests branch from 1c21c36 to 8bee3f0 Compare June 28, 2026 09:04
@Aaravanand00 Aaravanand00 changed the base branch from jazzy to rolling June 28, 2026 09:08
@Aaravanand00 Aaravanand00 force-pushed the fix-issue-282-atomic-param-tests branch from 8bee3f0 to d8c68b4 Compare June 28, 2026 09:10
…2#282)

Signed-off-by: Aaravanand00 <aaravanand5749@gmail.com>
@Aaravanand00 Aaravanand00 force-pushed the fix-issue-282-atomic-param-tests branch from d8c68b4 to fb3d20d Compare June 28, 2026 09:11
@Aaravanand00

Copy link
Copy Markdown
Author

sorry, can you target this against rolling branch? that is where we develop as mainline.

done ptal

@Aaravanand00

Copy link
Copy Markdown
Author

the original issue is almost 8 years ago, but this test case is still missing. lgtm. thanks for the contribution.

is there any other test that you should want me to resolve first then let me know

@fujitatomoya

Copy link
Copy Markdown

Pulls: #595
Gist: https://gist.githubusercontent.com/fujitatomoya/84ab0104e7b32755bfe16770af5c560a/raw/d487a8e4e11062dabae98967ff9c1f37b0c0e00f/ros2.repos
BUILD args: --packages-up-to test_rclcpp
TEST args: --packages-select test_rclcpp
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/19689

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[test_rclcpp] Add local and async set_parameters_atomically tests

2 participants