rtkrcv, rtknavi: support more input and solution out streams#892
Open
ourairquality wants to merge 2 commits into
Open
rtkrcv, rtknavi: support more input and solution out streams#892ourairquality wants to merge 2 commits into
ourairquality wants to merge 2 commits into
Conversation
When the options were opened the stream details were copied over only when the stream was enabled which lost the stream details when disabled. Change this to keep the stream details even if disabled, so that a stream can be disabled and re-enabled without having to reenter all the details.
83ce017 to
3ed6948
Compare
Move towards the number of input and output streams being a compilation option, adding the RTKSVRNIN, and RTKSVRNSOL defines and also make better use of MAXSTRRTK rather than baking in constants. Move the output streams to the end of the stream index range so that adding more does not affect indices of the input and log streams. rtkrcv and rtknavi now accepts one more input and one more output stream, and rtkrcv now builds with up to 5 input and 6 output streams and could support more by simply adding move config options for them.
3ed6948 to
7d5d2f6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This builds on and replaces #762 and also adds a define for the number of input streams to replace many constants that were baked into the code (and easy to miss debugging this), and this adds an extra input stream from rtkrcv and rtknavi.
e.g. Find this useful, at least in testing, to be able to add an extra input stream for ephemeris such as BCEP00BKG0 while also having an SSR corrections stream.
Move towards the number of input and output streams being a compilation option, adding the RTKSVRNIN, and RTKSVRNSOL defines and also make better use of MAXSTRRTK rather than baking in constants. Move the output streams to the end of the stream index range so that adding more does not affect indices of the input and log streams.
rtkrcv and rtknavi now accepts one more input and one more output stream, and rtkrcv now builds with up to 5 input and 6 output streams and could support more by simply adding move config options for them.