rtknavi_qt: keep the stream details even if disabled#893
Open
ourairquality wants to merge 1 commit into
Open
Conversation
When the options were opened the stream details were copied over only when the stream was enabled which lost the stream details when disabled. Change this to keep the stream details even if disabled, so that a stream can be disabled and re-enabled without having to reenter all the details.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed the stream details being lost when disabling and then re-enabling a stream, and it occurred when the options were opened with the stream disabled. The stream details were not being cleared when a stream was disabled otherwise.
When the options were opened the stream details were copied over only when the stream was enabled which lost the stream details when disabled. Change this to keep the stream details even if disabled, so that a stream can be disabled and re-enabled without having to reenter all the details.