Parallelize DC discovery and improve diagnostics and UI reliability#26
Open
zbalkan wants to merge 26 commits into
Open
Parallelize DC discovery and improve diagnostics and UI reliability#26zbalkan wants to merge 26 commits into
zbalkan wants to merge 26 commits into
Conversation
Signed-off-by: Zafer Balkan <zafer@zaferbalkan.com>
… into major-version
Major version
Author
|
This PR became larger than I expected. I screwed up with parallelization and over-engineered and started from scratch, then quit. Thanks to LLMs, I get my old branches reviewed and merged them into this but it does a lot for a single PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR delivers a major reliability and performance update for domain controller discovery and replication checks. It parallelizes long-running discovery operations, improves progress reporting, routes DC-override discovery through the selected domain controller, and strengthens diagnostics across the UI.
It also upgrades the project to .NET Framework 4.8.1, cleans up the WinForms implementation, and reorganizes supporting code and project structure.
Key changes
Discovery and replication
volatileto reduce stale-state risk across worker-thread usage.UI reliability
TreeListViewupdates toRunWorkerCompletedto avoid cross-thread UI access.ActiveFormusage with the current form instance.TreeListViewexpansion crash by defining explicitAspectGetterandChildrenGetterhandlers.Close()where appropriate for more predictable dialog behavior.Diagnostics
Housekeeping
ADREPLDC..editorconfig.1.4.0.0.