Need to update MiniTest adapter.#33
Open
av-ast wants to merge 3 commits into
Open
Conversation
|
👍 |
|
Actual for me too. @sconover can you review? |
Collaborator
|
I'm finally looking into this; unfortunately minitest_test.rb fails -- many times on Minitest 5.2.2, twice on Minitest 5.0.6. I'll have to spend more time digging. |
|
@alexch Do you have any WIP related to minitest 5 you could push? I tried looking into it but didn't get far. It would help if the big changes got a starting direction from one of the maintainers tho. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've tried
wrongwith the latest minitest version 5.0.6 and it failed.UnitTest#test_assert_true:
NoMethodError: undefined method
_assertions' for #<UnitTest:0x00000101143ed8> /Users/ava/git/wrong/lib/wrong/adapters/minitest.rb:13:inaver'/Users/ava/git/wrong/lib/wrong/assert.rb:34:in
assert' unit_test.rb:6:intest_assert_true'Since the latest version MiniTest uses
assertionsinstead of_assertions.Also, this PR will replace the gem source with proper 'https://rubygems.org' and will remove deprecation message.