refactor: support closing all connections to a db in Rust#51
Open
onehumandev wants to merge 1 commit into
Open
refactor: support closing all connections to a db in Rust#51onehumandev wants to merge 1 commit into
onehumandev wants to merge 1 commit into
Conversation
Author
jjhafer
requested changes
Jun 11, 2026
velocitysystems
suggested changes
Jun 11, 2026
onehumandev
force-pushed
the
onehumandev/close_invocation
branch
3 times, most recently
from
5aabb86 to
648d309
Compare
Previously, the only way to close the connection to a database was through a command invocation, which is only available through IPC. We need the ability to close any open connections to a db in Rust. For example if we are performing file operations (such as deleting and recreating the db) from the Rust layer, we need to first ensure all connections are closed before taking any further action. This simple refactor breaks the logic to close any open connections into a public function callable from Rust.
onehumandev
force-pushed
the
onehumandev/close_invocation
branch
from
648d309 to
99fe607
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the only way to close the connection to a database was through a command invocation, which is only available through IPC.
We need the ability to close any open connections to a db in Rust.
For example if we are performing file operations (such as deleting and recreating the db) from the Rust layer, we need to first ensure all connections are closed before taking any further action.
This simple refactor breaks the logic to close any open connections into a public function callable from Rust.
The logic is unchanged.