fix: quote convert dry-run identifiers#747
Open
Gares95 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
convert --dry-runso table and column identifiers are quoted using the existingquote_identifier()helper.What changed
quote_identifier().].Why
The normal
convertpath already usesquote_identifier(), but the dry-run preview path built SQL using square brackets directly. That meant valid identifiers containing]could fail in--dry-runeven though the actual conversion path handled them correctly.This keeps dry-run behavior consistent with the main conversion path.
Tests
Ran:
Result:
Compatibility notes
This only changes generated SQL for the dry-run preview query. Existing ordinary table and column names should behave the same, while identifiers requiring escaping now use the same quoting approach as the main convert implementation.
📚 Documentation preview 📚: https://sqlite-utils--747.org.readthedocs.build/en/747/