Enable migration integration tests#1157
Draft
mxsrc wants to merge 13 commits into
Draft
Conversation
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
mxsrc
force-pushed
the
ftt2-integration
branch
2 times, most recently
from
62ed0cb to
2e40ffd
Compare
The instances are not updated when the snapshot's owning volume is migrated. This patches the on-node-predicate to account for that, pending a proper fix in the instance handling.
Retries would lead to the `m`-suffix being applied multiple times. Using the idempotent helper avoids this.
mxsrc
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The migration tests have been disabled so far and needed fixes to pre-existing failures, as well as adapting to logic changes.