Fix context propagation in execute operations#459
Open
timothyF95 wants to merge 8 commits into
Open
Conversation
j-nowak
previously approved these changes
May 29, 2026
j-nowak
requested changes
Jun 1, 2026
Comment on lines
+136
to
+144
| // executionContext returns the context from Execute(), or context.Background() | ||
| // when handler methods are invoked directly in unit tests. | ||
| func (h *handler) executionContext() context.Context { | ||
| if h.execCtx != nil { | ||
| return h.execCtx | ||
| } | ||
| return context.Background() | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
I don't like the pattern, where in the production code we have a branch for testing. It is a code smell and creates a higher risk for bugs and issues.
Why can't we have one of those:
- Create handler with
contextas constructor param - Pass
ctxas a function params where needed and then don't store it as ahandlerfield?
Contributor
Author
There was a problem hiding this comment.
I think it would be better to pass the ctx as a parameter. It did make testing challenging
Contributor
There was a problem hiding this comment.
This is a code smell, and can cause a lot of weird bugs in the future. We shouldn't mutate a field like that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA
https://smartcontract-it.atlassian.net/browse/DEVSVCS-4957