Gradle upgrade#115
Draft
soerendomroes wants to merge 8 commits into
Draft
Conversation
soerendomroes
commented
Jun 11, 2026
| // TODO help menus keep disappearing and is offset | ||
| menu(graphic = sochaIcon) { | ||
| item("Beenden", "Shortcut+Q").action { | ||
| logger.debug("Quitting!") |
Member
Author
There was a problem hiding this comment.
Why the random changes? Is logger.debug() deprecated?
| arrayOf("year", "minor", "patch").map { versions["socha.version.$it"].toString().toInt() }.joinToString(".") + suffix | ||
| } | ||
|
|
||
| group = "sc.gui" |
Member
Author
There was a problem hiding this comment.
Why do you change this?
| implementation(kotlin("reflect")) | ||
|
|
||
|
|
||
| implementation(files("./gradle/tornadofx2-21e933fd41.jar")) |
Comment on lines
+116
to
+117
| ) | ||
| // included because of tornadofx already |
Member
Author
There was a problem hiding this comment.
I do not understand this change.
Comment on lines
-45
to
-50
| ### Java-Versionen und Abhängigkeiten | ||
|
|
||
| Aktuell können die Backend-docs nur mit JDK 8 gebaut werden, | ||
| dieses Projekt braucht jedoch für [tornadofx](https://github.com/edvin/tornadofx2) | ||
| mindestens Java 11. | ||
| Daher müssen die Releases separat gebaut werden. |
Member
Author
There was a problem hiding this comment.
Could you readd the documentation about the current java version and limitations?
What Java version do I need?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.