(Draft) New Data Model#480
Draft
SKernchen wants to merge 281 commits into
Draft
Conversation
cont.active_ctx is very special with regards to the implementation of a dependency. This is ugly and tests will be added to test_pyld_utils.
The conversion tests (`_to_python` and `_to_expanded_json`) are pretty long now...
This reverts commit 4fe4ffb.
This reverts commit df5b0ef.
This reverts commit d825217.
This reverts commit 8b4f9a3.
Pull in relevant changes from `develop`
Disable tests that fail due to data model
Resolve #383: Test `ld_context`
…or/381-test-ld_container # Conflicts: # poetry.lock
…e and changed the way commands handle errors in plugin runs
Fix #454: Add end-to-end tests for the plugin-related `SoftwareMetadata` API
…c-api Refactor/423 implement public api
zyzzyxdonta
reviewed
May 26, 2026
Contributor
zyzzyxdonta
left a comment
zyzzyxdonta
left a comment
There was a problem hiding this comment.
Some first very high-level comments. Will continue the review another day.
Contributor
There was a problem hiding this comment.
Should a top-level conftest exist? I think this belongs into test/ or test/hermes_test/
| "pynacl>=1.5.0, <2.0.0", | ||
| "rdflib (>=7.1.4,<8.0.0)", | ||
| "schemaorg (>=0.1.1,<0.2.0)", | ||
| "tomlkit (>=0.14.0,<0.15.0)", |
Contributor
There was a problem hiding this comment.
This is our second toml dependency (we already had toml. And there is also tomli as a transitive dependency. It might make sense to consolidate this into one implementation at some point, if possible.
| codemeta = "hermes.commands.process.standard_merge:CodemetaProcessPlugin" | ||
|
|
||
| [project.entry-points."hermes.curate"] | ||
| pass_curate = "hermes.commands.curate.pass_curate:DoNothingCuratePlugin" |
Contributor
There was a problem hiding this comment.
"do nothing" and "pass" are two different names for the same thing. We should make up our minds and choose one of the two.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is not ready yet. It is only for showing the process