refactor: CustomException은 이중 래핑하지 않고 던지도록

[whqtker]

관련 이슈

• resolves: refactor: 모의 지원 시 성적을 선택하지 않은 경우 적절한 예외를 리턴하도록 #790

작업 내용

private Object proceedJoinPoint(ProceedingJoinPoint joinPoint) {
    try {
        return joinPoint.proceed();
    } catch (Throwable e) {
        throw new RuntimeException("Error during proceedJoinPoint", e);
    }
}

// executeWithLock 메서드
} catch (Exception e) {
    throw new RuntimeException("Error during executeWithLock", e);
}

조인포인트에서 예외가 발생한 경우 런타임 예외를 던지고, 이를 executeWithLock 메서드에서 CustomException은 별도로 처리하지 않고 Exception을 받아 런타임 에러로 던집니다.

즉, CustomException이 발생하더라도 결과적으로 500 에러가 발생하게 됩니다.

이에 CustomException인 경우 미리 던지도록 수정합니다.

특이 사항

리뷰 요구사항 (선택)

[coderabbitai]

Warning

Review limit reached

@whqtker, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 47 minutes and 20 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more credits in the billing tab to continue.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 628717ab-5073-45b0-96ca-d01c6ec66040

📥 Commits

Reviewing files that changed from the base of the PR and between 793eee8 and b0079ad.

📒 Files selected for processing (1)

• src/test/java/com/example/solidconnection/university/service/UnivApplyInfoQueryServiceTest.java

Walkthrough

ThunderingHerdCachingAspect 클래스에 CustomException import가 추가되었습니다. 이에 따라 executeWithLock 메서드와 proceedJoinPoint 메서드 각각에 CustomException을 별도로 catch하는 블록이 삽입되었습니다. 해당 블록에서는 CustomException을 RuntimeException으로 래핑하지 않고 원본 예외 그대로 재throw합니다. 그 외의 Exception 및 Throwable은 기존과 동일하게 RuntimeException으로 래핑되어 던져집니다.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	제목이 CustomException의 중복 래핑 제거라는 핵심 변경을 정확히 요약합니다.
Description check	✅ Passed	관련 이슈와 작업 내용이 포함되어 있고, 템플릿의 필수 구조를 대부분 충족합니다.
Linked Issues check	✅ Passed	#790의 도메인 예외를 직접 던지도록 하는 요구와 변경 내용이 일치합니다.
Out of Scope Changes check	✅ Passed	요구사항과 무관한 변경은 보이지 않고 예외 처리 리팩터링만 포함됩니다.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/790-thundering-herd-exception-wrapping

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}