Skip to content

fix: 마이 프로필 변경 버튼 클릭 영역 수정#591

Merged
manNomi merged 2 commits into
mainfrom
fix/mentor-click-area
Jun 30, 2026
Merged

fix: 마이 프로필 변경 버튼 클릭 영역 수정#591
manNomi merged 2 commits into
mainfrom
fix/mentor-click-area

Conversation

@manNomi

@manNomi manNomi commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

관련 이슈

  • 없음

작업 내용

  • 마이 페이지의 프로필 변경 버튼에서 버튼처럼 보이던 바깥 div를 제거했습니다.
  • Link가 버튼 전체 스타일과 폭을 직접 가지도록 변경해 텍스트뿐 아니라 버튼 전체 영역이 클릭되도록 수정했습니다.
  • 잘못 반영했던 멘토 채널 링크 수정은 PR diff에서 제거했습니다.

특이 사항

  • 동작 변경 범위는 마이 페이지 프로필 변경 링크 클릭 영역으로 한정했습니다.
  • 로컬 Node 버전이 v23.10.0이라 node 22.x 엔진 경고가 출력됐지만 검증은 통과했습니다.

리뷰 요구사항 (선택)

  • 마이 페이지에서 멘토/멘티 상태 모두 프로필 변경 버튼 전체가 /my/modify로 이동하는지 확인 부탁드립니다.

검증

  • pnpm --filter @solid-connect/web run lint:check
  • pnpm --filter @solid-connect/web run typecheck:ci
  • pre-commit/pre-push hook CI parity checks 통과
  • pnpm --filter @solid-connect/web run build

@vercel

vercel Bot commented Jun 30, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
solid-connect-university-web Ready Ready Preview, Comment Jun 30, 2026 6:10am
solid-connection-web Ready Ready Preview, Comment Jun 30, 2026 6:10am
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
solid-connect-web-admin Skipped Skipped Jun 30, 2026 6:10am

@coderabbitai

coderabbitai Bot commented Jun 30, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@manNomi, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 55 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: a8bf97b1-f474-4fba-aac3-8af1cbf1ae87

📥 Commits

Reviewing files that changed from the base of the PR and between 740318d and 6d8f67a.

📒 Files selected for processing (1)
  • apps/web/src/app/my/_ui/MyProfileContent/index.tsx

Walkthrough

  1. MentorDetialContent — Link 래퍼 className 변경

    • 기존 템플릿 문자열 방식의 조건부 클래스 계산을 clsx로 교체했습니다.
    • block h-10 w-full이 모든 채널 항목에 공통 적용됩니다.
    • channels.length === 3 && idx === 2일 때만 col-span-2가 추가됩니다.
  2. MentorCard — 채널 a 태그 className 변경

    • 기존에는 channels.length === 1일 때만 w-full을 적용하고, 길이 3이면서 마지막 인덱스일 때 col-span-2를 적용하던 방식이었습니다.
    • 변경 후에는 clsx를 사용해 모든 채널 항목에 block h-10 w-full이 기본 적용됩니다.
    • channels.length === 3 && idx === 2 조건에서만 col-span-2가 추가됩니다.
    • ⚠️ channels.length === 1일 때만 w-full을 적용하던 기존 조건이 제거되어, 채널이 2개일 때도 w-full이 적용되는 동작 변화가 발생합니다.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers

  • wibaek
  • enunsnv
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning 제목은 프로필 변경 버튼을 가리키지만 실제 변경은 멘토 채널 링크 클릭 영역이라 핵심 변경과 어긋납니다. 실제 변경 대상인 멘토 채널 링크 클릭 영역이 드러나도록 제목을 수정하세요.
✅ Passed checks (4 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description check ✅ Passed 필수 섹션을 모두 갖추고 있으며 작업 내용, 특이 사항, 리뷰 요구사항이 구체적으로 작성되어 있습니다.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/mentor-click-area

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@vercel vercel Bot temporarily deployed to Preview – solid-connect-web-admin June 30, 2026 06:06 Inactive
@manNomi manNomi changed the title fix: 멘토 채널 링크 클릭 영역 수정 fix: 마이 프로필 변경 버튼 클릭 영역 수정 Jun 30, 2026
@manNomi manNomi marked this pull request as draft June 30, 2026 06:07
@manNomi manNomi marked this pull request as ready for review June 30, 2026 06:07
@manNomi

manNomi commented Jun 30, 2026

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Can't wait for the next one!

Reviewed commit: 6d8f67a672

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@manNomi manNomi merged commit d8753d2 into main Jun 30, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant