[codex] Delay Rqueue startup for Boot web apps#303
Open
sonus21 wants to merge 12 commits into
Open
Conversation
Coverage Report for CI Build 26326038935Warning No base build found for commit Coverage: 83.426%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsRequires a base build to compare against. How to fix this → Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Delays Rqueue listener container auto-start in Spring Boot web applications until
ApplicationReadyEvent, covering both servlet and reactive web apps through Boot's web application condition. Non-web Boot applications keep the existingSmartLifecyclestartup behavior.Root cause
RqueueMessageListenerContaineris aSmartLifecyclebean, so Spring can auto-start pollers during context refresh before the embedded web server is fully ready. Web apps should let the Boot server finish startup before pollers begin consuming work.Changes
RqueueAutoStartupLifecycleto disable container auto-start only for containers that originally opted into auto-start, then start them onApplicationReadyEvent.@ConditionalOnWebApplication, so servlet and WebFlux are covered while non-web workers are unchanged.RqueueMessageListenerContainer.start()idempotent and setrunningonly afterdoStart()succeeds.Validation
./gradlew :rqueue-core:test --tests com.github.sonus21.rqueue.listener.RqueueMessageListenerContainerTest :rqueue-spring-boot-starter:test --tests com.github.sonus21.rqueue.spring.boot.tests.unit.RqueueListenerAutoConfigTest./gradlew :rqueue-spring-boot-starter:test --tests com.github.sonus21.rqueue.spring.boot.tests.unit.RqueueListenerAutoConfigTest