49 add union find data structure#62
Open
c-m-elliott wants to merge 56 commits into
Open
Conversation
added 30 commits
May 25, 2026 13:52
…tor implementation
…concerns and notes in a comment
…t for subsets to HashMap
… mismatches that will be sorted out later on if I decide to stick with HashMaps
…by size in UnsortedUnionFind
…w private method contains(T e)
…ure maps fulfil set requirement
…) as static method problematic due to variable type
…ionFind; adapt interfaces accordingly
…by size in SortedUnionFindTest
added 23 commits
June 17, 2026 17:16
…in SortedTreeSetUnionFind
…in SortedTreeSetUnionFind
…est for now as it does not meet codestyle requirements and a quick fix is not available at the moment
…ortedUnionFindTest to ensure the canonical elements of subsets do not change at times they shouldn't (during union by size)
…ical element in UnionFind and SortedUnionFind
… entirely sure what I did though so someone qualified will need to look it over
…in the first place
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So far, this includes the interfaces UnionFind, SortedUnionFind, PersistentUnionFind and PersistentSortedUnionFind as well as the abstract classes AbstractImmutableUnionFind and AbstractImmutableSortedUnionFind. It also contains a naive implementation of SortedUnionFind based on a HashMap of TreeSets (SortedTreeSetUnionFind). There is a set of tests (SortedUnionFindTest), but there seems to be some kind of problem regarding null values which is causing the JDK21 PackageSanityTest to fail. This in particular is something I'd appreciate input on. Thanks!