Update dataset editor file browser modal to use spx theme css

[klpoland]

Note

Medium Risk
Large front-end change to dataset file picking (selection state, folder bulk select, and DOM structure); regression risk in create/edit flows, though API auth test change is low risk.

Overview
Replaces the dataset file browser modal table (#file-tree-table) with a SpectrumX .file-browser-modal tree (#file-tree-root), including new theme CSS for click-to-select rows, visually hidden checkboxes, and folder expand/collapse.

AssetSearchHandler now builds the tree with DOM APIs (not HTML strings), adds folder selection mode (toggle to select/deselect all selectable files under a folder), Clear selections, guarded one-time event binding, and Enter-key handling on file search. Call sites (PageLifecycleManager, create/edit handlers) point at #file-tree-root; edit mode blocks accidental form submit on Enter.

The file_browser.html partial gains folder-mode controls and help text. Minor test fix: unauthenticated dataset-files test uses a fresh APIClient instead of force_authenticate(None). Cursor rules document preferring safe DOM construction for user-controlled text.

^{Reviewed by Cursor Bugbot for commit a4a87c7. Bugbot is set up for automated code reviews on this repo. Configure here.}

[semanticdiff-com]

Review changes with  

Changed Files

File	Status
gateway/sds_gateway/api_methods/tests/test_dataset_endpoints.py	42% smaller
gateway/sds_gateway/templates/users/partials/file_browser.html	37% smaller
gateway/sds_gateway/static/js/search/AssetSearchHandler.js	7% smaller
gateway/sds_gateway/static/js/search/__tests__/AssetSearchHandler.test.js	1% smaller
.cursor/rules/django_javascript_implementation.mdc	Unsupported file format
gateway/sds_gateway/static/css/components.css	0% smaller
gateway/sds_gateway/static/css/spectrumx_theme.css	0% smaller
gateway/sds_gateway/static/js/core/PageLifecycleManager.js	0% smaller
gateway/sds_gateway/static/js/dataset/DatasetCreationHandler.js	0% smaller
gateway/sds_gateway/static/js/dataset/DatasetEditingHandler.js	0% smaller

[creinkin]

bugbot run

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 3 potential issues.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.

^{Reviewed by Cursor Bugbot for commit a4a87c7. Configure here.}

[cursor]

Modal selection still expects table

High Severity

The file browser's structure changed to li elements, but handleModalFileSelection and getFileDataFromRow still expect tr and td elements. This mismatch causes getFileDataFromRow to throw an error when processing file selections, including 'select all', breaking file selection in dataset creation.

 

^{Reviewed by Cursor Bugbot for commit a4a87c7. Configure here.}

[cursor]

Enter guard blocks textarea lines

Medium Severity

The new datasetForm keypress handler calls preventDefault on every Enter key, including Enter pressed inside multiline fields such as the dataset description, so users cannot insert new lines while editing.

 

^{Reviewed by Cursor Bugbot for commit a4a87c7. Configure here.}

[cursor]

Expanded folders stay hidden

High Severity

Folder rows set aria-expanded on the li and nest child lists as li > ul, but theme CSS hides every .file-browser li > ul and only shows ul as a sibling of [aria-expanded="true"]. Nested lists never become visible, so expanding folders in the modal does not reveal files or subfolders.

Additional Locations (1)

• gateway/sds_gateway/static/css/spectrumx_theme.css#L413-L565

 

^{Reviewed by Cursor Bugbot for commit a4a87c7. Configure here.}