Skip to content

add genetric metrics for external API#1228

Open
aniruddha2000 wants to merge 5 commits into
mainfrom
add-generic-metrics
Open

add genetric metrics for external API#1228
aniruddha2000 wants to merge 5 commits into
mainfrom
add-generic-metrics

Conversation

@aniruddha2000

Copy link
Copy Markdown
Member

How to categorize this PR?

/kind enhancement

What this PR does / why we need it:

This PR enables using generic metrics for all the external API (IaaS & Loadbalancer) and also track error code more than 400 unlike 500 previously.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Breaking changes:

@ske-prow ske-prow Bot added the kind/enhancement Enhancement, improvement, extension label Jun 15, 2026
@ske-prow

ske-prow Bot commented Jun 15, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign xoxys for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ske-prow ske-prow Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 15, 2026
@aniruddha2000

Copy link
Copy Markdown
Member Author

/ondemand create

@ske-prow

ske-prow Bot commented Jun 15, 2026

Copy link
Copy Markdown

Hey @aniruddha2000, I'm managing your ondemand environment ond-yak. I've successfully transitioned from phase "preheated" to "provisioning".

👩‍🌾 Gardener Dashboard
🚀 STACKIT Portal

How to Connect

Retrieve kubeconfig to interact with the environment with kubectl ske (assuming you're connected to the prow-trusted cluster):

gardenctl target --garden prd --project 74140853d0 --shoot prow-trust
kubectl ske connect ondemand ond-yak

To connect to the API, you can retrieve the Password from the prow-trusted cluster:

export BASIC_AUTH_USERNAME=$(kubectl get -n ondemand secret ond-yak-credentials -ojsonpath='{.data.username}' | base64 -d)
export BASIC_AUTH_PASSWORD=$(kubectl get -n ondemand secret ond-yak-credentials -ojsonpath='{.data.password}' | base64 -d)
export PROJECT_ID=$(kubectl get -n ondemand secret ond-yak-credentials -ojsonpath='{.data.projectID}' | base64 -d)
export SNA_PROJECT_ID=$(kubectl get -n ondemand secret ond-yak-credentials -ojsonpath='{.data.snaProjectID}' | base64 -d)
export SKE_API=https://ske-api.ing.ond-yak.ci.ske.eu01.stackit.cloud
curl -u "$BASIC_AUTH_USERNAME:$BASIC_AUTH_PASSWORD" "$SKE_API/v2/projects/$PROJECT_ID/regions/eu01/clusters"

@ske-prow

ske-prow Bot commented Jun 15, 2026

Copy link
Copy Markdown

Hey @aniruddha2000, I'm managing your ondemand environment ond-yak. I've successfully transitioned from phase "provisioning" to "provisioned".

👩‍🌾 Gardener Dashboard
🚀 STACKIT Portal

How to Connect

Retrieve kubeconfig to interact with the environment with kubectl ske (assuming you're connected to the prow-trusted cluster):

gardenctl target --garden prd --project 74140853d0 --shoot prow-trust
kubectl ske connect ondemand ond-yak

To connect to the API, you can retrieve the Password from the prow-trusted cluster:

export BASIC_AUTH_USERNAME=$(kubectl get -n ondemand secret ond-yak-credentials -ojsonpath='{.data.username}' | base64 -d)
export BASIC_AUTH_PASSWORD=$(kubectl get -n ondemand secret ond-yak-credentials -ojsonpath='{.data.password}' | base64 -d)
export PROJECT_ID=$(kubectl get -n ondemand secret ond-yak-credentials -ojsonpath='{.data.projectID}' | base64 -d)
export SNA_PROJECT_ID=$(kubectl get -n ondemand secret ond-yak-credentials -ojsonpath='{.data.snaProjectID}' | base64 -d)
export SKE_API=https://ske-api.ing.ond-yak.ci.ske.eu01.stackit.cloud
curl -u "$BASIC_AUTH_USERNAME:$BASIC_AUTH_PASSWORD" "$SKE_API/v2/projects/$PROJECT_ID/regions/eu01/clusters"

@aniruddha2000

Copy link
Copy Markdown
Member Author

/ondemand create --ske-base-branch=add-generic-metrics

@ske-prow

ske-prow Bot commented Jun 16, 2026

Copy link
Copy Markdown

Hey @aniruddha2000, you've asked for an ondemand environment. The OnDemandEnvironment ond-yak has already been assigned to this issue/PR, so I can't allocate another. 🫣

@aniruddha2000

Copy link
Copy Markdown
Member Author

/ondemand edit --ske-base-branch=add-generic-metrics

@ske-prow

ske-prow Bot commented Jun 16, 2026

Copy link
Copy Markdown

Hey @aniruddha2000, I'm managing your ondemand environment ond-yak. I've successfully transitioned from phase "provisioned" to "provisioning".

👩‍🌾 Gardener Dashboard
🚀 STACKIT Portal

How to Connect

Retrieve kubeconfig to interact with the environment with kubectl ske (assuming you're connected to the prow-trusted cluster):

gardenctl target --garden prd --project 74140853d0 --shoot prow-trust
kubectl ske connect ondemand ond-yak

To connect to the API, you can retrieve the Password from the prow-trusted cluster:

export BASIC_AUTH_USERNAME=$(kubectl get -n ondemand secret ond-yak-credentials -ojsonpath='{.data.username}' | base64 -d)
export BASIC_AUTH_PASSWORD=$(kubectl get -n ondemand secret ond-yak-credentials -ojsonpath='{.data.password}' | base64 -d)
export PROJECT_ID=$(kubectl get -n ondemand secret ond-yak-credentials -ojsonpath='{.data.projectID}' | base64 -d)
export SNA_PROJECT_ID=$(kubectl get -n ondemand secret ond-yak-credentials -ojsonpath='{.data.snaProjectID}' | base64 -d)
export SKE_API=https://ske-api.ing.ond-yak.ci.ske.eu01.stackit.cloud
curl -u "$BASIC_AUTH_USERNAME:$BASIC_AUTH_PASSWORD" "$SKE_API/v2/projects/$PROJECT_ID/regions/eu01/clusters"

@ske-prow ske-prow Bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 16, 2026
@ske-prow ske-prow Bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 16, 2026
@ske-prow

ske-prow Bot commented Jun 16, 2026

Copy link
Copy Markdown

@aniruddha2000: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cloud-provider-stackit-verify 961c15e link true /test pull-cloud-provider-stackit-verify

Full PR test history. Your PR dashboard. Command help for this repository.
Please help us cut down on flakes by linking this test failure to an open flake report or filing a new flake report if you can't find an existing one. Also see the gardener testing guideline for how to avoid and hunt flakes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/enhancement Enhancement, improvement, extension size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant