Skip to content

chore(kms): migrate kms to new multi version sdk#1437

Merged
cgoetz-inovex merged 3 commits into
mainfrom
chore/STACKITCLI-364-kms-sdk-migration
Jun 16, 2026
Merged

chore(kms): migrate kms to new multi version sdk#1437
cgoetz-inovex merged 3 commits into
mainfrom
chore/STACKITCLI-364-kms-sdk-migration

Conversation

@cgoetz-inovex

Copy link
Copy Markdown
Contributor

STACKITCLI-364

Description

relates to #1234

Checklist

  • Issue was linked above
  • Code format was applied: make fmt
  • Examples were added / adjusted (see e.g. here)
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • Unit tests got implemented or updated
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@cgoetz-inovex cgoetz-inovex requested a review from a team as a code owner June 12, 2026 13:59
GokceGK
GokceGK previously approved these changes Jun 16, 2026
@github-actions

Copy link
Copy Markdown

Merging this branch will decrease overall coverage

Impacted Packages Coverage Δ 🤖
github.com/stackitcloud/stackit-cli/internal/cmd/kms/key/create 50.00% (-7.63%) 👎
github.com/stackitcloud/stackit-cli/internal/cmd/kms/key/delete 46.51% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/kms/key/describe 76.79% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/kms/key/importKey 52.94% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/kms/key/list 43.90% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/kms/key/restore 46.51% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/kms/key/rotate 50.00% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/kms/keyring/create 43.14% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/kms/keyring/delete 34.38% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/kms/keyring/describe 65.79% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/kms/keyring/list 39.47% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/kms/version/destroy 60.53% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/kms/version/disable 53.19% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/kms/version/enable 53.19% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/kms/version/list 43.90% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/kms/version/restore 60.53% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/kms/wrappingkey/create 48.98% (-7.92%) 👎
github.com/stackitcloud/stackit-cli/internal/cmd/kms/wrappingkey/delete 41.67% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/kms/wrappingkey/describe 76.79% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/kms/wrappingkey/list 42.86% (ø)
github.com/stackitcloud/stackit-cli/internal/pkg/services/kms/client 0.00% (ø)
github.com/stackitcloud/stackit-cli/internal/pkg/services/kms/utils 83.33% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/stackitcloud/stackit-cli/internal/cmd/kms/key/create/create.go 50.00% (-7.63%) 50 (-9) 25 (-9) 25 👎
github.com/stackitcloud/stackit-cli/internal/cmd/kms/key/delete/delete.go 46.51% (ø) 43 20 23
github.com/stackitcloud/stackit-cli/internal/cmd/kms/key/describe/describe.go 76.79% (ø) 56 43 13
github.com/stackitcloud/stackit-cli/internal/cmd/kms/key/importKey/importKey.go 52.94% (ø) 51 27 24
github.com/stackitcloud/stackit-cli/internal/cmd/kms/key/list/list.go 43.90% (ø) 41 18 23
github.com/stackitcloud/stackit-cli/internal/cmd/kms/key/restore/restore.go 46.51% (ø) 43 20 23
github.com/stackitcloud/stackit-cli/internal/cmd/kms/key/rotate/rotate.go 50.00% (ø) 40 20 20
github.com/stackitcloud/stackit-cli/internal/cmd/kms/keyring/create/create.go 43.14% (ø) 51 22 29
github.com/stackitcloud/stackit-cli/internal/cmd/kms/keyring/delete/delete.go 34.38% (ø) 32 11 21
github.com/stackitcloud/stackit-cli/internal/cmd/kms/keyring/describe/describe.go 65.79% (ø) 38 25 13
github.com/stackitcloud/stackit-cli/internal/cmd/kms/keyring/list/list.go 39.47% (ø) 38 15 23
github.com/stackitcloud/stackit-cli/internal/cmd/kms/version/destroy/destroy.go 60.53% (ø) 38 23 15
github.com/stackitcloud/stackit-cli/internal/cmd/kms/version/disable/disable.go 53.19% (ø) 47 25 22
github.com/stackitcloud/stackit-cli/internal/cmd/kms/version/enable/enable.go 53.19% (ø) 47 25 22
github.com/stackitcloud/stackit-cli/internal/cmd/kms/version/list/list.go 43.90% (ø) 41 18 23
github.com/stackitcloud/stackit-cli/internal/cmd/kms/version/restore/restore.go 60.53% (ø) 38 23 15
github.com/stackitcloud/stackit-cli/internal/cmd/kms/wrappingkey/create/create.go 48.98% (-7.92%) 49 (-9) 24 (-9) 25 👎
github.com/stackitcloud/stackit-cli/internal/cmd/kms/wrappingkey/delete/delete.go 41.67% (ø) 36 15 21
github.com/stackitcloud/stackit-cli/internal/cmd/kms/wrappingkey/describe/describe.go 76.79% (ø) 56 43 13
github.com/stackitcloud/stackit-cli/internal/cmd/kms/wrappingkey/list/list.go 42.86% (ø) 42 18 24
github.com/stackitcloud/stackit-cli/internal/pkg/services/kms/client/client.go 0.00% (ø) 1 0 1
github.com/stackitcloud/stackit-cli/internal/pkg/services/kms/utils/utils.go 83.33% (ø) 24 20 4

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/stackitcloud/stackit-cli/internal/cmd/kms/key/create/create_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/kms/key/delete/delete_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/kms/key/describe/describe_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/kms/key/importKey/importKey_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/kms/key/list/list_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/kms/key/restore/restore_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/kms/key/rotate/rotate_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/kms/keyring/create/create_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/kms/keyring/delete/delete_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/kms/keyring/describe/describe_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/kms/keyring/list/list_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/kms/version/destroy/destroy_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/kms/version/disable/disable_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/kms/version/enable/enable_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/kms/version/list/list_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/kms/version/restore/restore_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/kms/wrappingkey/create/create_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/kms/wrappingkey/delete/delete_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/kms/wrappingkey/describe/describe_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/kms/wrappingkey/list/list_test.go
  • github.com/stackitcloud/stackit-cli/internal/pkg/services/kms/utils/utils_test.go

@cgoetz-inovex cgoetz-inovex merged commit 6fd51b3 into main Jun 16, 2026
3 checks passed
@cgoetz-inovex cgoetz-inovex deleted the chore/STACKITCLI-364-kms-sdk-migration branch June 16, 2026 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants