ci: Add workflow_dispatch to e2e workflows for manual re-runs#21594
Open
AlexVulaj wants to merge 1 commit into
Open
ci: Add workflow_dispatch to e2e workflows for manual re-runs#21594AlexVulaj wants to merge 1 commit into
AlexVulaj wants to merge 1 commit into
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Central YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (4)
🚧 Files skipped from review as they are similar to previous changes (3)
📝 WalkthroughSummary by CodeRabbit
WalkthroughFour GitHub Actions e2e workflows now accept manual ChangesWorkflow dispatch support
Estimated code review effort: 1 (Trivial) | ~5 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/e2e-byodb-test.yaml:
- Line 31: The job condition using inputs.should-run is ambiguous and can
unintentionally skip workflow_dispatch executions; update the workflow logic to
make the dispatch behavior explicit. Adjust the conditional on the affected job
in the e2e-byodb-test workflow to guard for workflow_dispatch separately, or
define should-run with a default so its value is always clear, and keep the
check aligned with the job-level if expression.
In @.github/workflows/e2e-db-backup-restore-test.yaml:
- Line 31: The job guard in the workflow is checking inputs.should-run, but that
input is not defined for workflow_dispatch, so manual runs skip the job. Update
the workflow definition to declare should-run under workflow_dispatch with a
default value, or change the if condition in the affected job to use a guard
that works when the input is unset. Use the job’s existing if condition and the
workflow_dispatch inputs block as the places to fix this.
In @.github/workflows/e2e-gke-upgrade-tests.yaml:
- Line 33: The upgrade-test jobs are being skipped on manual runs because
`inputs.should-run != false` is false when the input is unset. Update the
workflow’s `workflow_dispatch` configuration to define `should-run` with a
default of true, or change the job guard to explicitly handle an empty input,
and apply the fix consistently across the relevant job conditions in the
workflow.
In @.github/workflows/e2e-nongroovy-tests.yaml:
- Line 31: The e2e-nongroovy-tests workflow job condition is using a loose
comparison on inputs.should-run, which causes manual workflow_dispatch runs to
be skipped when the input is unset. Update the job’s if expression to explicitly
check for the expected string value (for example, against 'true') or define the
workflow_dispatch input in the workflow so the condition in the job definition
evaluates correctly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Central YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 0ab67a00-81df-4c8d-8ff2-1639ea6c3e2c
📒 Files selected for processing (4)
.github/workflows/e2e-byodb-test.yaml.github/workflows/e2e-db-backup-restore-test.yaml.github/workflows/e2e-gke-upgrade-tests.yaml.github/workflows/e2e-nongroovy-tests.yaml
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #21594 +/- ##
==========================================
- Coverage 50.37% 50.33% -0.05%
==========================================
Files 2844 2844
Lines 218476 218476
==========================================
- Hits 110054 109964 -90
- Misses 100437 100510 +73
- Partials 7985 8002 +17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
🚀 Build Images ReadyImages are ready for commit 25dfb3f. To use with deploy scripts: export MAIN_IMAGE_TAG=4.12.x-406-g25dfb3fafd |
AlexVulaj
force-pushed
the
add-workflow-dispatch-to-e2e
branch
from
b027b5a to
25dfb3f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
workflow_dispatchtriggers to individual e2e test workflows so they can be manually re-run from the Actions tab without waiting for the fulle2e-dispatchpipeline to finish. Changesif: inputs.should-runtoif: inputs.should-run != falseso manual triggers (whereshould-runis null) still execute.User-facing documentation
Testing and quality
Automated testing
How I validated my change
CI-only change. The
workflow_dispatchtrigger adds a manual "Run workflow" button in the Actions tab. The!= falsecondition is equivalent to the previous behavior when called frome2e-dispatch(whereshould-runis explicitlytrueorfalse) and additionally allows runs whenshould-runis null (manual dispatch).