fix(view): break ui.view.react ↔ workspace.view.react cycle#2
Open
mkotelnikov wants to merge 2 commits into
Open
fix(view): break ui.view.react ↔ workspace.view.react cycle#2mkotelnikov wants to merge 2 commits into
mkotelnikov wants to merge 2 commits into
Conversation
ui.view.react imported DirectoryPickerEmptyState from workspace.view.react, while workspace.view.react imports from ui.view.react — a circular package dependency that turbo refuses to build. DirectoryPickerEmptyState was workspace.view.react's only public export and isn't used by its own code; it only needs ui.view.react hooks + workspace.browser. Relocate it into ui.view.react (which renders it), making the edge one-directional (workspace.view.react -> ui.view.react). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
mime.view.{image,markdown,pdf,video} import @statewalker/shared-slots in their
init but never declared it — a phantom dependency that resolves in the umbrella's
hoisted node_modules but breaks a fresh isolated install (e.g. the apps-umbrella
parent). Declare it explicitly.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ui.view.reactandworkspace.view.reactform a circular package dependency:ui.view.reactimportsDirectoryPickerEmptyStatefromworkspace.view.react, whileworkspace.view.reactimports fromui.view.react(5 files). pnpm tolerates it (warns); turbo refuses to build it, breaking any freshturbo build.Fix
DirectoryPickerEmptyStatewasworkspace.view.react's only public export and isn't used by its own code (only an init.ts comment). It only needsui.view.reacthooks +ui.view.shadcn+workspace.browser— notworkspace.view.react. Relocated it intoui.view.react(which renders it via<App/>), making the edge one-directional (workspace.view.react → ui.view.react).directory-picker-empty-state.tsx→ui.view.react/src/internal/ui.view.react: export it; drop theworkspace.view.reactdep; addui.view.shadcn+lucide-react(used by the component)app.tsx: import it locallyVerified
Full
turbo buildof both apps + the whole dependency graph: 30/30 tasks, exit 0 (was blocked by the cycle before).🤖 Generated with Claude Code