Skip to content

compile without warnings#218

Open
zeuner wants to merge 13 commits into
stingergraph:devfrom
zeuner:fix-warnings
Open

compile without warnings#218
zeuner wants to merge 13 commits into
stingergraph:devfrom
zeuner:fix-warnings

Conversation

@zeuner

@zeuner zeuner commented Jan 28, 2017

Copy link
Copy Markdown

I cleaned up the code a bit in order to compile warning-free on gcc 6.0. This should be helpful for better maintainability and portability.


This change is Reviewable

@davidediger

Copy link
Copy Markdown
Collaborator

@zeuner Might take us a little bit to review all of this, but thanks for the help. Standby...

@zeuner

zeuner commented Feb 7, 2017

Copy link
Copy Markdown
Author

Inform me if anything is unclear.

Some remarks:

  • Might be good to document intents regarding const qualifiers - most warnings were due to const correctness

  • There may be better ways to ensure strict pointer aliasing (lib/stinger_core/src/stinger.c, stinger_outdegree_get)

Conflicts:
	lib/stinger_utils/src/stinger_utils.c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants