feat: add compile flag for board family#2977
Merged
Merged
Conversation
Ex: -DARDUINO_NUCLEO_64 By Default for all Gerneric: -DARDUINO_GENERIC Fixes stm32duino#2976. Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
|
Looks great to me. I actually started working on this myself this morning so I was surprised to get your notice about this. I was prepending to *.build.st_extra_flags; that didn't require changing platforms.txt. |
Member
Author
|
Adding to st_extra_flags was an other solution but it is often override at board level. So it requires to add the define for all boards which override it. The way done in this PR requires only one define per high level menu and allows a default value for all generic menu. |
github-project-automation
Bot
moved this from In progress
to Done
in STM32 core based on ST HAL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ex:
-DARDUINO_NUCLEO_64By Default for all Gerneric:
-DARDUINO_GENERICFixes #2976.