Skip to content

Port main2 Python fixes to Strata-Python#2

Merged
joehendrix merged 10 commits into
mainfrom
port/main2-python-fixes
Jun 16, 2026
Merged

Port main2 Python fixes to Strata-Python#2
joehendrix merged 10 commits into
mainfrom
port/main2-python-fixes

Conversation

@shigoel

@shigoel shigoel commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Summary

Ports all main2-only Python commits to the split Strata-Python repo as part of the main2 → main sync (Strata PR #1363).

  • Fix Python for-loop translation: continue now advances the counter (#1302)
  • Fix missing s! prefix in parseStrataProgramFromDialect error messages (#1285)
  • Formatting and debugging improvements (#1115)
  • Change "unreachable" assertion message (#1296)
  • Procedure.Body sum type threading (#1342)
  • Support transparent procedures (#1215)

All commits preserve original authorship and dates.

Depends on: Strata PR #1370 (Strata dependency temporarily pinned to port/main2-core-to-main — will change to main after merge).

⚠️ Merge with merge commit (not squash) to preserve individual commit attribution.

Test plan

  • lake build passes (218 jobs)
  • lake build StrataPythonTest passes (compile-time tests)
  • CI passes (golden-file tests need pip install of strata-python)

leo-leesco and others added 7 commits June 15, 2026 12:28
Tools/Python-base (the `strata` pip package) was removed from Strata
in PR #1351 as part of the repo split. Move it here so that
Strata-Python is self-contained for its Python dependencies.

Update CI to install from ./Tools/Python-base instead of
./.lake/packages/Strata/Tools/Python-base.

Co-authored-by: Aaron Tomb <aarotomb@amazon.com>
@shigoel shigoel force-pushed the port/main2-python-fixes branch from 95db39e to bb69bbc Compare June 15, 2026 20:32
leo-leesco and others added 3 commits June 15, 2026 15:00
Without s!, "{pythonCmd}" prints as a literal string instead of
interpolating the variable. Same pattern as commit 729a4174b
(Fix #1244). Carried to main2 via merge #1311.
Strata PR #1370 has been merged. Update lakefile.toml rev from
"port/main2-core-to-main" to "main" and update lake-manifest.json.

@aqjune-aws aqjune-aws left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that the contents are consistent with the StrataPython/ dir of main2 branch of Strata, modulo script and doc updates. The script and doc updates looked reasonable to me.

@joehendrix joehendrix marked this pull request as ready for review June 16, 2026 21:54
@joehendrix joehendrix requested a review from a team June 16, 2026 21:54
@joehendrix joehendrix merged commit 055a0bf into main Jun 16, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants