fix(core): close Reaper socket at interpreter exit to prevent ResourceWarning#1017
Merged
alexanderankin merged 1 commit intoMay 22, 2026
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1017 +/- ##
==========================================
+ Coverage 82.82% 83.01% +0.19%
==========================================
Files 16 16
Lines 1723 1725 +2
Branches 189 189
==========================================
+ Hits 1427 1432 +5
+ Misses 240 236 -4
- Partials 56 57 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…eWarning
The Ryuk keep-alive socket stored in `Reaper._socket` was never explicitly
closed, so CPython's GC finalized it during interpreter shutdown and emitted
a ResourceWarning ("unclosed <socket.socket ...>") that is impossible to
suppress via warnings filters because it fires after pytest exits.
Registering `Reaper.delete_instance` with `atexit` ensures the socket is closed
cleanly before the GC sweep, eliminating the warning without changing the
socket's lifetime during the test session.
Signed-off-by: Edgar Ramírez Mondragón <edgarrm358@gmail.com>
4d391b2 to
33fae08
Compare
alexanderankin
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Ryuk keep-alive socket stored in
Reaper._socketwas never explicitlyclosed, so CPython's GC finalized it during interpreter shutdown and emitted
a ResourceWarning ("unclosed <socket.socket ...>") that is impossible to
suppress via warnings filters because it fires after pytest exits.
Registering
Reaper.delete_instancewithatexitensures the socket is closedcleanly before the GC sweep, eliminating the warning without changing the
socket's lifetime during the test session.