Handle transient navigation errors before browser recovery#59
Merged
Conversation
DavertMik
approved these changes
Jun 25, 2026
DavertMik
requested changes
Jun 25, 2026
DavertMik
left a comment
Contributor
There was a problem hiding this comment.
I smell overengineering here
Playwright must already handle situations like loading DOM tree with doc content loaded, so I don't think we need to re-implement it
HOWEVER, if you open a project in testomat.io there is a page spinner and content is not loaded, why dom is loaded
so the fix you need must be smarter:
to understand by XHR network requests and spinner classes on page if it is in loading mode.
please USE playwright api, do not re-implement it!
wait for all XHR requests settled on page load || all spinner classes to be hidden (spinner classes can be configured) || timeout
Promise.race(
xhr requests.
timeout,
spinners
)
DavertMik
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prevents transient SPA navigation errors from immediately triggering browser recovery and page reloads.
When Playwright throws navigation-related context errors during page capture or state verification, Explorbot now waits for the page DOM/URL to settle and retries before falling back to
browser recovery.