Skip to content

πŸ›‘οΈ Sentinel: [CRITICAL] Fix Path Traversal in AbstractDiskBasedService#89

Open
tomdesair wants to merge 2 commits into
masterfrom
sentinel-path-traversal-fix-13325561132426758992
Open

πŸ›‘οΈ Sentinel: [CRITICAL] Fix Path Traversal in AbstractDiskBasedService#89
tomdesair wants to merge 2 commits into
masterfrom
sentinel-path-traversal-fix-13325561132426758992

Conversation

@tomdesair

Copy link
Copy Markdown
Owner

🚨 Severity: CRITICAL
πŸ’‘ Vulnerability: A Path Traversal vulnerability was present in AbstractDiskBasedService.java where the UploadId is used to construct paths into the storage directory without validating if it escapes the directory boundaries.
🎯 Impact: An attacker could potentially read, overwrite, or delete arbitrary files on the system outside the designated upload directory.
πŸ”§ Fix: Normalized the resulting path and ensured it securely starts with the absolute, normalized base storage path. Added a IllegalArgumentException check for invalid values.
βœ… Verification: mvn clean compile test passes, ensuring valid uploads are not impacted.


PR created automatically by Jules for task 13325561132426758992 started by @tomdesair

Co-authored-by: tomdesair <14034630+tomdesair@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coveralls

coveralls commented Jun 14, 2026

Copy link
Copy Markdown

Coverage Status

coverage: 94.813% (-0.1%) from 94.92% β€” sentinel-path-traversal-fix-13325561132426758992 into master

Co-authored-by: tomdesair <14034630+tomdesair@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants