π‘οΈ Sentinel: [CRITICAL] Fix Path Traversal in AbstractDiskBasedService#89
π‘οΈ Sentinel: [CRITICAL] Fix Path Traversal in AbstractDiskBasedService#89tomdesair wants to merge 2 commits into
Conversation
Co-authored-by: tomdesair <14034630+tomdesair@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Co-authored-by: tomdesair <14034630+tomdesair@users.noreply.github.com>
π¨ Severity: CRITICAL
π‘ Vulnerability: A Path Traversal vulnerability was present in
AbstractDiskBasedService.javawhere theUploadIdis used to construct paths into the storage directory without validating if it escapes the directory boundaries.π― Impact: An attacker could potentially read, overwrite, or delete arbitrary files on the system outside the designated upload directory.
π§ Fix: Normalized the resulting path and ensured it securely starts with the absolute, normalized base storage path. Added a
IllegalArgumentExceptioncheck for invalid values.β Verification:
mvn clean compile testpasses, ensuring valid uploads are not impacted.PR created automatically by Jules for task 13325561132426758992 started by @tomdesair