Conversation
What was broken PMs and copilots could see that an assigned member had not agreed to required terms, but the work app only rendered the API error text and did not provide a direct terms URL to send to the member. Root cause The challenge editor normalized save failures to a plain string and rendered that string directly, even when the selected challenge terms and terms catalog were available in the editor. What was changed The challenge editor now detects the missing-terms save error, matches the referenced terms against the currently selected challenge terms, and renders each matched term title as a link to the public Topcoder terms detail page. Manual form submit failures now rely on the visible save error state instead of surfacing an unhandled rejected promise after the UI has handled the failure. Any added/updated tests Added a ChallengeEditorForm regression test that verifies a missing-terms save error renders the selected term as a terms detail link.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
PMs and copilots could see that an assigned member had not agreed to required terms, but the work app only rendered the API error text and did not provide a direct terms URL to send to the member.
Root cause
The challenge editor normalized save failures to a plain string and rendered that string directly, even when the selected challenge terms and terms catalog were available in the editor.
What was changed
The challenge editor now detects the missing-terms save error, matches the referenced terms against the currently selected challenge terms, and renders each matched term title as a link to the public Topcoder terms detail page. Manual form submit failures now rely on the visible save error state instead of surfacing an unhandled rejected promise after the UI has handled the failure.
Any added/updated tests
Added a ChallengeEditorForm regression test that verifies a missing-terms save error renders the selected term as a terms detail link.
Validation notes: