Skip to content

Add environments delete command#293

Open
jo-sm wants to merge 2 commits into
developfrom
feature/env-deletion
Open

Add environments delete command#293
jo-sm wants to merge 2 commits into
developfrom
feature/env-deletion

Conversation

@jo-sm

@jo-sm jo-sm commented Jun 11, 2026

Copy link
Copy Markdown
Member

This PR adds a new environments delete command to the CLI. Depends on #292.

@coderabbitai

coderabbitai Bot commented Jun 11, 2026 •
edited
Loading

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 8af10845-5a72-4ff8-a364-1bbea3de697c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/env-deletion

Comment @coderabbitai help to get the list of available commands and usage tips.

Base automatically changed from chore/update-client to develop June 11, 2026 16:46
@jo-sm jo-sm force-pushed the feature/env-deletion branch from 5dda65a to d256b65 Compare June 12, 2026 08:41
socksy
socksy reviewed Jun 12, 2026
View reviewed changes

@socksy socksy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleting itself seems fine, but I'm pretty sure we should have an interactive prompt and/or --dangerously-confirm-force-deletion-of-environment (or you know, something snappier) before I would approve

Comment thread crates/tower-cmd/src/api.rs
}
}

impl ResponseEntity for tower_api::apis::default_api::DeleteEnvironmentSuccess {

@socksy socksy Jun 12, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file is autogenerated, right? If not, I hate it :D

Comment thread crates/tower-cmd/src/environments.rs Outdated
@jo-sm jo-sm requested a review from socksy June 15, 2026 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bradhe bradhe Awaiting requested review from bradhe

@konstantinoscs konstantinoscs Awaiting requested review from konstantinoscs

@socksy socksy Awaiting requested review from socksy

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jo-sm @socksy