Conversation
…nstances
Deleting a framework that had published versions and/or org instances failed
with a 409 ("referenced by existing framework instances"). The delete only
removed requirements + the framework, so the FrameworkVersion / FrameworkInstance
FK references remained — and cascading versions + instances together trips the
Restrict FK on FrameworkInstance.currentVersionId (P2003).
Delete the dependency graph in explicit order inside the transaction: instances
(cascades their org controls/maps/links/sync-operations and frees the
currentVersion FK) -> versions -> requirements -> the framework (cascades the
editor-side control/policy/task/document links + ISMS docs).
Also makes the editor delete confirmation honest about the blast radius (it now
removes published versions and any org instances too). The controller is
PlatformAdminGuard-only, so this stays an internal-admin operation.
Closes FRAME-13
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…ersion Reverts the FRAME-4 "Save and Commit" flow: committing changes immediately prompted to publish a new version. Per Joe (FRAME-14), publishing is a separate, deliberate activity — editors commit in batches of 5-10 and do a full pass before publishing a meaningful version. This restores the single "Commit Changes" button (save edits to the live templates, no publish prompt). Publishing remains available as its own action on the framework's Versions tab. Reverts commit bb7064b. Closes FRAME-14 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…ramework fix(framework-editor): allow deleting a framework with versions/instances (FRAME-13)
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
…t-from-publish fix(framework-editor): commit changes independently of publishing (FRAME-14)
Contributor
|
🎉 This PR is included in version 3.83.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated pull request to release the candidate branch into production, which will trigger a deployment.
It was created by the [Production PR] action.
Summary by cubic
Fixes deletion of frameworks that have published versions or org instances (FRAME-13) and decouples publishing from committing requirement edits (FRAME-14). Deletion now runs in a safe order in one transaction, and editing shows a single Commit Changes button with no publish prompt.
db.$transaction; map PrismaP2003toConflictException; update delete dialog copy.PublishVersionDialogwiring.Written for commit 51f2ca3. Summary will update on new commits.