Conversation
… framework Follow-up to #3154. Deleting a framework still 409'd in prod ("could not delete framework: it still has references that could not be removed automatically") because TimelineTemplate.frameworkId is a Restrict FK back to the framework and a TimelineTemplate is created per framework — the previous cascade missed it. Delete TimelineTemplates in the transaction, right after instances (so their TimelineInstances/phases have already cascade-deleted, freeing the Restrict FK TimelineInstance.templateId -> TimelineTemplate). Verified via an exhaustive scan that requirements + timeline templates are now the only non-cascade FKs into FrameworkEditorFramework, and versions/instances are handled. Closes FRAME-13 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…rk-timeline-fix fix(framework-editor): also delete timeline templates on framework delete (FRAME-13 follow-up)
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
|
🎉 This PR is included in version 3.83.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated pull request to release the candidate branch into production, which will trigger a deployment.
It was created by the [Production PR] action.
Summary by cubic
Fixes framework deletion by also removing timeline templates in the correct order, preventing Restrict FK conflicts and 409s in production. Links to FRAME-13.
timelineTemplate.deleteManyright after instance deletion in the transaction to satisfy Restrict FKs.Written for commit 2341924. Summary will update on new commits.