Conversation
… footgun) The API-key placeholder was `comp_…your_key_here…` using a literal ellipsis (U+2026). Customers who copied it kept the `…`, and the MCP server then failed to serialize the x-api-key header — Node throws "character at index 5 has a value of 8230 which is greater than 255" on every tool call (customer-reported). Replace every copy-paste placeholder with plain ASCII (`comp_your_api_key_here`), drop the ellipsis from the surrounding prose, and add a troubleshooting entry for the encoding error. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…y schedule Dynamic (DB-backed) integrations — Keeper, Supabase, and ~575 others — never ran on the daily schedule; they only ran on manual "Run" clicks. Root cause: the orchestrator (integration-checks-schedule) and worker (run-task-integration-checks) run in the Trigger.dev runtime, whose manifest registry is seeded only with the 8 static code manifests. The dynamic-manifest loader is a NestJS OnModuleInit service that never runs there, so getManifest(dynamicSlug) returns undefined and the orchestrator silently skipped those connections. Manual runs work because they execute in the API process where the loader has populated the registry. Fix (mirrors the existing AWS server-delegation): - Orchestrator discovers dynamic task mappings straight from the DB (DynamicCheck.taskMapping / isEnabled) via resolveProviderChecks, so static providers still resolve from the code manifest and win when both exist. - Worker + auto-run-on-connect delegate dynamic providers to the API server (runChecksOnServer → the provider-agnostic ConnectionCheckRunner), where the dynamic manifest is loaded. shouldRunOnServer = aws || (no local manifest && active dynamic). A truly unknown provider still early-returns instead of crashing. Static integrations and AWS are unchanged (the in-process path only runs when a manifest is present). Also fixes scheduled auto-run-on-connect for dynamic providers. Tests: new dynamic-provider.spec (shouldRunOnServer + isActiveDynamicProvider) and resolveProviderChecks cases; 21 trigger/integration-platform tests pass. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
docs(mcp): fix API-key placeholder encoding footgun (ellipsis in header)
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Addresses cubic review on #3165: `/*.csv` and `/dbq_*.js` only matched repo-root files, so an exported customer CSV or a creds-bearing ops script in a subfolder could still be tracked. Drop the leading slash so the rules apply at any depth. Verified zero `.csv`/`dbq_*.js` files are currently tracked, so nothing legitimate is hidden or needs untracking. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…s-scheduled-runs fix(integration-platform): run dynamic integration checks on the daily schedule
Contributor
|
🎉 This PR is included in version 3.83.6 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated pull request to release the candidate branch into production, which will trigger a deployment.
It was created by the [Production PR] action.
Summary by cubic
Restores scheduled checks for dynamic integrations by delegating their runs to the API server and letting the scheduler read DB-backed check maps when no manifest exists. Also fixes
@trycompai/mcp-serverAPI‑key placeholders and tightens.gitignore.comp_…your_key_here…withcomp_your_api_key_herein all@trycompai/mcp-serverexamples and added a troubleshooting note for U+2026 header errors; unanchored.gitignorerules to excludedbq_*.jsand*.csvat any depth.Written for commit a86bc7b. Summary will update on new commits.