Conversation
Admin-role users got "Access Denied" submitting evidence forms (e.g.
/documents/risk-committee-meeting/new) while Owners could. The evidence-form
submit/upload/my-submissions endpoints are gated on `portal:update`
(evidence-forms.controller.ts) — chosen so employees can self-submit from the
portal — but the built-in `admin` role had no `portal` statement at all. Owner
and employee/contractor had `portal:['read','update']`; admin and auditor did
not, so admins were denied. The CS workaround was granting the Employee role.
Fix: add `portal:['read','update']` to the admin role so admins can submit
evidence forms directly, mirroring owner. Auditor is intentionally left
unchanged (read-only). Updated the two guarding specs that encoded the old
"admins get portal only via the employee role" policy.
Side effect (intended): a pure-admin user can now log into the employee portal,
same as owner already could. Invite-email behavior is unchanged (it keys off the
compliance obligation, which admin still lacks).
Verified against the built @trycompai/auth dist running real better-auth:
admin.authorize({portal:['update']}).success === true, auditor === false,
owner/employee unchanged.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…mission fix(auth): grant admin role portal permission to submit evidence forms (CS-550)
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
|
🎉 This PR is included in version 3.83.8 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated pull request to release the candidate branch into production, which will trigger a deployment.
It was created by the [Production PR] action.
Summary by cubic
Grant the built-in
adminroleportal: ['read','update']so admins can submit evidence forms and access the employee portal without adding the Employee role (CS-550). Updated RBAC tests;auditorremains denied.Written for commit 0997932. Summary will update on new commits.