Conversation
fix(integration-platform): fail closed on partial environment coverage
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
1 issue found across 13 files
Confidence score: 3/5
- In
packages/integration-platform/src/manifests/environment-aliases.ts, conflicting entries inenvironment_aliasesare silently overwritten, so a typo or ordering change can map an environment incorrectly and cause downstream misclassification at runtime. Add explicit duplicate/conflict validation (and a failing test case) so invalid alias sets are rejected before merging.
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
fix(integration-platform): reject duplicate environment aliases
Contributor
|
🎉 This PR is included in version 3.86.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated pull request to release the candidate branch into production, which will trigger a deployment.
It was created by the [Production PR] action.
Summary by cubic
Adds environment alias support and makes environment-separation checks fail closed on partial coverage across AWS, Azure, and GCP. Improves findings with alias evidence and clear counts of unclassified resources.
New Features
environment_aliasesonaws,azure, andgcpmanifests; aliases are used when classifying from tags/names/labels and are included in evidence.Bug Fixes
Written for commit 3109cb8. Summary will update on new commits.