chore: 🐝 Update SDK - Generate 0.2.1#3202
Conversation
|
|
609e817 to
3b39c4a
Compare
There was a problem hiding this comment.
6 issues found and verified against the latest diff
Confidence score: 2/5
- In
apps/mcp-server/src/funcs/ismsISMSRegistersControllerSaveNarrativeV1.ts,apps/mcp-server/src/funcs/ismsISMSControllerEnsureSetupV1.ts, andapps/mcp-server/src/funcs/ismsISMSProfileControllerSaveProfileV1.ts, request bodies are declared but not sent, so key POST calls can no-op or fail validation and users cannot persist setup/profile/narrative data — wire each_request/payload into_createRequestand verify with an integration call before merging. - In
apps/mcp-server/src/models/updateobjectivedto.ts(and the related generated DTOs called out), empty{}DTO schemas mean objective/interested-party/risk payloads cannot carry update fields, making those endpoints effectively unusable from this SDK — regenerate or correct the DTO model mappings so expected properties are preserved before merge. - In
apps/mcp-server/src/models/ismsregisterscontrollerdeleteinterestedpartyv1op.ts,partyIdaccepting empty strings can produce/v1/isms/interested-parties/requests and confusing downstream API errors — tighten validation (for example non-empty/UUID) to fail fast client-side. - In
apps/mcp-server/src/models/ismsprofilecontrollergetprofilev1op.ts, the OAuth2 description is mislabeled as API key auth, which can mislead MCP consumers during integration — update the schema text for clarity (can be a quick follow-up if release timing is tight).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="apps/mcp-server/src/models/ismsprofilecontrollergetprofilev1op.ts">
<violation number="1" location="apps/mcp-server/src/models/ismsprofilecontrollergetprofilev1op.ts:16">
P2: oauth2 field description incorrectly says "API Key". Should describe OAuth2 auth, not API key auth. Causes confusion for MCP tool consumers reading the schema.</violation>
</file>
<file name="apps/mcp-server/src/models/ismsregisterscontrollerdeleteinterestedpartyv1op.ts">
<violation number="1" location="apps/mcp-server/src/models/ismsregisterscontrollerdeleteinterestedpartyv1op.ts:24">
P2: `partyId` Zod schema accepts empty strings. A blank partyId will pass client-side validation but produce a request to `/v1/isms/interested-parties/` (trailing slash with no ID), leading to a confusing API error. Add `.min(1)` to reject empty values early.</violation>
</file>
<file name="apps/mcp-server/src/models/updateobjectivedto.ts">
<violation number="1" location="apps/mcp-server/src/models/updateobjectivedto.ts:7">
P1: `UpdateObjectiveDto` is an empty object `{}`, so the update-objective endpoint will always send/accept an empty body — no fields can be updated. Same issue affects CreateObjectiveDto, both InterestedParty DTOs, both Requirement DTOs, both ContextIssue DTOs, EnsureIsmsSetupDto, and LinkIsmsControlsDto. Root cause is in the OpenAPI component schemas; fix there before regenerating.</violation>
</file>
Tip: instead of fixing issues one by one fix them all with cubic
Re-trigger cubic
|
|
||
| import * as z from "zod"; | ||
|
|
||
| export type UpdateObjectiveDto = {}; |
There was a problem hiding this comment.
P1: UpdateObjectiveDto is an empty object {}, so the update-objective endpoint will always send/accept an empty body — no fields can be updated. Same issue affects CreateObjectiveDto, both InterestedParty DTOs, both Requirement DTOs, both ContextIssue DTOs, EnsureIsmsSetupDto, and LinkIsmsControlsDto. Root cause is in the OpenAPI component schemas; fix there before regenerating.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At apps/mcp-server/src/models/updateobjectivedto.ts, line 7:
<comment>`UpdateObjectiveDto` is an empty object `{}`, so the update-objective endpoint will always send/accept an empty body — no fields can be updated. Same issue affects CreateObjectiveDto, both InterestedParty DTOs, both Requirement DTOs, both ContextIssue DTOs, EnsureIsmsSetupDto, and LinkIsmsControlsDto. Root cause is in the OpenAPI component schemas; fix there before regenerating.</comment>
<file context>
@@ -0,0 +1,10 @@
+
+import * as z from "zod";
+
+export type UpdateObjectiveDto = {};
+
+export const UpdateObjectiveDto$zodSchema: z.ZodType<UpdateObjectiveDto> = z
</file context>
| IsmsProfileControllerGetProfileV1Security | ||
| > = z.object({ | ||
| apikey: z.string().describe("API key for authentication").optional(), | ||
| oauth2: z.string().describe("API Key").optional(), |
There was a problem hiding this comment.
P2: oauth2 field description incorrectly says "API Key". Should describe OAuth2 auth, not API key auth. Causes confusion for MCP tool consumers reading the schema.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At apps/mcp-server/src/models/ismsprofilecontrollergetprofilev1op.ts, line 16:
<comment>oauth2 field description incorrectly says "API Key". Should describe OAuth2 auth, not API key auth. Causes confusion for MCP tool consumers reading the schema.</comment>
<file context>
@@ -0,0 +1,25 @@
+ IsmsProfileControllerGetProfileV1Security
+> = z.object({
+ apikey: z.string().describe("API key for authentication").optional(),
+ oauth2: z.string().describe("API Key").optional(),
+});
+
</file context>
|
|
||
| export const IsmsRegistersControllerDeleteInterestedPartyV1Request$zodSchema: | ||
| z.ZodType<IsmsRegistersControllerDeleteInterestedPartyV1Request> = z.object({ | ||
| partyId: z.string(), |
There was a problem hiding this comment.
P2: partyId Zod schema accepts empty strings. A blank partyId will pass client-side validation but produce a request to /v1/isms/interested-parties/ (trailing slash with no ID), leading to a confusing API error. Add .min(1) to reject empty values early.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At apps/mcp-server/src/models/ismsregisterscontrollerdeleteinterestedpartyv1op.ts, line 24:
<comment>`partyId` Zod schema accepts empty strings. A blank partyId will pass client-side validation but produce a request to `/v1/isms/interested-parties/` (trailing slash with no ID), leading to a confusing API error. Add `.min(1)` to reject empty values early.</comment>
<file context>
@@ -0,0 +1,25 @@
+
+export const IsmsRegistersControllerDeleteInterestedPartyV1Request$zodSchema:
+ z.ZodType<IsmsRegistersControllerDeleteInterestedPartyV1Request> = z.object({
+ partyId: z.string(),
+ });
</file context>
…-profiles feat(browserbase): add per-site auth profiles
…-profiles [dev] [tofikwest] tofik/browser-automation-auth-profiles
…-profiles fix(browserbase): request identity encoded api responses
…down ## Problem Users can only filter by SOC2 and ISO27001 in the Overview > Findings view, even when their org has other frameworks enabled like ISO42001 or HIPAA. This blocks them from seeing findings specific to those frameworks. ## Root cause FindingsTab.tsx hardcodes the framework filter options to [all, soc2, iso27001] instead of deriving them from the org's actual enabled frameworks. The CreateFindingSheet on the same page does this correctly via the /v1/frameworks endpoint and extractOrgFrameworkTypes(), but the filter dropdown never got that fix. ## Fix Apply the same pattern from CreateFindingSheet to FindingsTab: fetch enabled frameworks at component load and use those to populate the filter dropdown. The client-side filter logic and FindingType enum already support all 7 framework types, so this is just surfacing what's already wired. ## Explicitly NOT touched Finding creation flow (already works correctly). The filter behavior when no frameworks are enabled (edge case, won't happen in practice). ## Verification ✅ org_69d943ca3fbbf2c473e97b0a now shows ISO42001 in the framework filter after enabling it ✅ findings correctly filter when selecting non-SOC2/ISO27001 frameworks ✅ hardcoded filter list replaced with dynamic org config ✅ no regression on existing SOC2/ISO27001 filtering
…-auth-flow fix(browserbase): make task auth flow primary
fix(findings): include all enabled frameworks in overview filter dropdown
e50365d to
44c6975
Compare
* `CompAi.Trust Portal.TrustPortalController_uploadCustomFrameworkBadge_v1()`: **Added** * `CompAi.Trust Portal.TrustPortalController_removeCustomFrameworkBadge_v1()`: **Added** * `CompAi.ISMS.IsmsController_ensureSetup_v1()`: **Added** * `CompAi.ISMS.IsmsController_getDocument_v1()`: **Added** * `CompAi.ISMS.IsmsController_addControls_v1()`: **Added** * `CompAi.ISMS.IsmsController_removeControl_v1()`: **Added** * `CompAi.ISMS.IsmsController_generate_v1()`: **Added** * `CompAi.ISMS.IsmsController_submitForApproval_v1()`: **Added** * `CompAi.ISMS.IsmsController_approve_v1()`: **Added** * `CompAi.ISMS.IsmsController_decline_v1()`: **Added** * `CompAi.ISMS.IsmsController_drift_v1()`: **Added** * `CompAi.ISMS.IsmsController_exportDocument_v1()`: **Added** * `CompAi.ISMS.IsmsRegistersController_createRow_v1()`: **Added** * `CompAi.ISMS.IsmsRegistersController_updateRow_v1()`: **Added** * `CompAi.ISMS.IsmsRegistersController_deleteRow_v1()`: **Added** * `CompAi.ISMS.IsmsRegistersController_saveNarrative_v1()`: **Added** * `CompAi.ISMS.IsmsProfileController_getProfile_v1()`: **Added** * `CompAi.ISMS.IsmsProfileController_saveProfile_v1()`: **Added** * `CompAi.ISMS.IsmsProfileController_generateAll_v1()`: **Added**
cf78502 to
5d198e7
Compare
SDK update
Versioning
Version Bump Type: [patch] - 🤖 (automated)
Tip
If updates to your OpenAPI document introduce breaking changes, be sure to update the
info.versionfield to trigger the correct version bump.Speakeasy supports manual control of SDK versioning through multiple methods.
Mcp-typescript SDK Changes:
CompAi.Trust Portal.TrustPortalController_uploadCustomFrameworkBadge_v1(): AddedCompAi.Trust Portal.TrustPortalController_removeCustomFrameworkBadge_v1(): AddedCompAi.ISMS.IsmsController_ensureSetup_v1(): AddedCompAi.ISMS.IsmsController_getDocument_v1(): AddedCompAi.ISMS.IsmsController_addControls_v1(): AddedCompAi.ISMS.IsmsController_removeControl_v1(): AddedCompAi.ISMS.IsmsController_generate_v1(): AddedCompAi.ISMS.IsmsController_submitForApproval_v1(): AddedCompAi.ISMS.IsmsController_approve_v1(): AddedCompAi.ISMS.IsmsController_decline_v1(): AddedCompAi.ISMS.IsmsController_drift_v1(): AddedCompAi.ISMS.IsmsController_exportDocument_v1(): AddedCompAi.ISMS.IsmsRegistersController_createRow_v1(): AddedCompAi.ISMS.IsmsRegistersController_updateRow_v1(): AddedCompAi.ISMS.IsmsRegistersController_deleteRow_v1(): AddedCompAi.ISMS.IsmsRegistersController_saveNarrative_v1(): AddedCompAi.ISMS.IsmsProfileController_getProfile_v1(): AddedCompAi.ISMS.IsmsProfileController_saveProfile_v1(): AddedCompAi.ISMS.IsmsProfileController_generateAll_v1(): AddedView full SDK changelog
OpenAPI Change Summary
View full report
Linting Report
0 errors, 233 warnings, 294 hintsView full report
MCP-TYPESCRIPT CHANGELOG
core: 1.3.2 - 2026-06-11
🐛 Bug Fixes
retries: 0.1.1 - 2026-05-27
🐝 New Features
Based on Speakeasy CLI 1.784.0
Last updated by Speakeasy workflow