fix(findings): include all enabled frameworks in overview filter dropdown#3208
Merged
Conversation
…down ## Problem Users can only filter by SOC2 and ISO27001 in the Overview > Findings view, even when their org has other frameworks enabled like ISO42001 or HIPAA. This blocks them from seeing findings specific to those frameworks. ## Root cause FindingsTab.tsx hardcodes the framework filter options to [all, soc2, iso27001] instead of deriving them from the org's actual enabled frameworks. The CreateFindingSheet on the same page does this correctly via the /v1/frameworks endpoint and extractOrgFrameworkTypes(), but the filter dropdown never got that fix. ## Fix Apply the same pattern from CreateFindingSheet to FindingsTab: fetch enabled frameworks at component load and use those to populate the filter dropdown. The client-side filter logic and FindingType enum already support all 7 framework types, so this is just surfacing what's already wired. ## Explicitly NOT touched Finding creation flow (already works correctly). The filter behavior when no frameworks are enabled (edge case, won't happen in practice). ## Verification ✅ org_69d943ca3fbbf2c473e97b0a now shows ISO42001 in the framework filter after enabling it ✅ findings correctly filter when selecting non-SOC2/ISO27001 frameworks ✅ hardcoded filter list replaced with dynamic org config ✅ no regression on existing SOC2/ISO27001 filtering
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Users can only filter by SOC2 and ISO27001 in the Overview > Findings view, even when their org has other frameworks enabled like ISO42001 or HIPAA. This blocks them from seeing findings specific to those frameworks.
Root cause
FindingsTab.tsx hardcodes the framework filter options to [all, soc2, iso27001] instead of deriving them from the org's actual enabled frameworks. The CreateFindingSheet on the same page does this correctly via the /v1/frameworks endpoint and extractOrgFrameworkTypes(), but the filter dropdown never got that fix.
Fix
Apply the same pattern from CreateFindingSheet to FindingsTab: fetch enabled frameworks at component load and use those to populate the filter dropdown. The client-side filter logic and FindingType enum already support all 7 framework types, so this is just surfacing what's already wired.
Explicitly NOT touched
Finding creation flow (already works correctly). The filter behavior when no frameworks are enabled (edge case, won't happen in practice).
Verification
✅ org_69d943ca3fbbf2c473e97b0a now shows ISO42001 in the framework filter after enabling it
✅ findings correctly filter when selecting non-SOC2/ISO27001 frameworks
✅ hardcoded filter list replaced with dynamic org config
✅ no regression on existing SOC2/ISO27001 filtering
Summary by cubic
Fixes the Overview > Findings framework filter so it shows all frameworks enabled for the org, not just SOC 2 and ISO 27001. Users can now filter findings for ISO 42001, HIPAA, GDPR, etc. (addresses CS-554).
/v1/frameworks?includeScores=falseviauseApiSWRandextractOrgFrameworkTypes; remove hardcoded list.FINDING_TYPE_LABELSfor labels with an "All frameworks" default.Written for commit 20f4de9. Summary will update on new commits.