Skip to content

feat: add Backstage Software Catalog entities for platform, chart, an…#7

Merged
tukue merged 8 commits into
mainfrom
feature/backstage-catalog
May 28, 2026
Merged

feat: add Backstage Software Catalog entities for platform, chart, an…#7
tukue merged 8 commits into
mainfrom
feature/backstage-catalog

Conversation

@tukue

@tukue tukue commented May 27, 2026

Copy link
Copy Markdown
Owner

No description provided.

@tukue tukue self-assigned this May 27, 2026

@amazon-q-developer amazon-q-developer Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review Summary

This PR adds Backstage Software Catalog entities for the platform infrastructure, but contains critical logic errors that block merge:

Critical Issues Requiring Fix:

  1. Circular Dependency: The simple-app-infra-code and app-chart components have a circular dependsOn relationship that will break Backstage catalog resolution
  2. Incorrect API Relationships: The application components (app-b and simple-app) incorrectly claim to provide the tenant-contract API when they actually consume it

These issues must be resolved before merge as they will cause Backstage to fail loading and processing the catalog entities.

Required Changes:

  • Remove circular dependency declarations between infrastructure repository and chart
  • Fix API provider/consumer relationships for application components

You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.

Comment thread catalog-info.yaml Outdated
Comment thread platform/apps/simple-app/catalog-info.yaml Outdated
Comment thread standardized-path/app/catalog-info.yaml Outdated
Comment on lines +13 to +14
dependsOn:
- component:simple-app-infra-code

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛑 Logic Error: Circular dependency with simple-app-infra-code. This component declares dependsOn: component:simple-app-infra-code, while the infra code (catalog-info.yaml:17) declares dependsOn: component:app-chart. This circular relationship will cause Backstage catalog resolution to fail. The chart should not depend on the infra repository - remove this dependency.

Suggested change
dependsOn:
- component:simple-app-infra-code
system: platform
providesApis:

Comment thread platform/apps/app-b/catalog-info.yaml Outdated
@tukue tukue added the enhancement New feature or request label May 27, 2026
@tukue tukue added this to the mvp milestone May 27, 2026
@tukue tukue merged commit 0fab515 into main May 28, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant