Skip to content

Fix: Resolve Chart Color Collisions & Expand Signal Palette#163

Merged
tzebrowski merged 2 commits into
mainfrom
fix/chart-color-collisions
Jun 27, 2026
Merged

Fix: Resolve Chart Color Collisions & Expand Signal Palette#163
tzebrowski merged 2 commits into
mainfrom
fix/chart-color-collisions

Conversation

@tzebrowski

Copy link
Copy Markdown
Owner
  • Expanded light and dark palettes to 25 unique, high-contrast colors.
  • Replaced string-hashing logic with sequential allocation for Math/Filtered signals to mathematically prevent duplicate colors.
  • Added catch for sIdx === 999 to ensure internal proxy signals follow the new sequential assignment.

- Expanded light and dark palettes to 25 unique, high-contrast colors.
- Replaced string-hashing logic with sequential allocation for Math/Filtered signals to mathematically prevent duplicate colors.
- Added catch for `sIdx === 999` to ensure internal proxy signals follow the new sequential assignment.
@github-actions

Copy link
Copy Markdown

Coverage after merging fix/chart-color-collisions into main will be

85.40%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   alert.js95.65%88.89%100%100%19
   analysis.js89.86%80.65%85.29%96.40%114, 124, 137, 15, 18, 187, 216–217, 22, 229, 23, 32, 39, 47, 90, 94
   bus.js94.59%75%100%100%36, 39
   chartmanager.js61.07%49.88%66.67%66.76%1007–1008, 1008, 1008, 1008, 1008, 1008, 1008–1009, 1013–1014, 1014, 1014–1015, 1018–1019, 1019, 1019–1020, 1023, 1023, 1025, 103, 1036, 1036, 1036–1039, 1039, 1039–1041, 1047, 1050–1052, 1058, 1058, 1058–1061, 1067, 1069–1071, 1077, 1077, 1077–1078, 108, 1080–1082, 1085, 1087, 1089, 109, 1091, 1091, 1091–1095, 1097–1098, 1098, 1098–1101, 1101, 1101, 1103, 1103, 1103, 1103, 1103–1108, 1113–1115, 1115, 1115, 1117, 1119, 1127, 1127, 1141, 1143–1145, 1148, 1150, 1150, 1150–1151, 1153, 1153, 1153–1154, 1162–1163, 1167, 1167, 1167–1170, 1176, 1176, 1176–1180, 1180, 1180–1181, 1181, 1181–1184, 119, 1191, 1199–1201, 1203–1207, 1207, 1207–1209, 1213, 1213, 1213–1214, 1214, 1214–1216, 1218, 1223, 1223–1225, 1225, 1225, 1228, 1228, 1228–1229, 1229, 1229–1231, 1233, 1242–1243, 1287–1288, 1290, 1290, 1290, 1290, 1290, 1290, 1290, 1290, 1290, 1290, 1292–1293, 1299–1300, 1303–1304, 1306–1307, 1309–1310, 1313–1314, 1316, 1319, 1339–1340, 1346–1347, 1347, 1347–1349, 1362, 1378, 1384, 1384–1387, 1389, 1389, 1389, 1389, 1389, 1391, 1391, 1391–1392, 1395–1397, 1399–1400, 1400, 1400–1403, 1403, 1403, 1405, 1405, 1405, 1405, 1405–1409, 1415–1416, 1416, 1416–1417, 1419–1420, 1425, 1425, 1425–1426, 1428, 1428, 1428–1430, 1436, 1442, 1442, 1442–1446, 1449–1452, 1452, 1452, 1456–1457, 1465–1470, 1486, 1507, 1541–1542, 157–158, 168, 172, 175–176, 182–185, 185, 185–186, 186, 186–187, 220, 226, 253–255, 274–276, 290–292, 295–296, 298–300, 302, 329, 332, 337, 340, 344, 354–355, 355, 359, 38, 398, 405, 413, 413–415, 442, 59, 605, 610, 614, 629, 63, 633, 65, 652–655, 657, 66, 664, 675, 68, 68, 68, 683–684, 69, 693, 698, 70, 707, 71, 714, 719, 73, 733–734, 734, 734–735, 735, 735, 737, 74, 74, 74–75, 754, 756, 76, 76, 76–77, 77, 787, 789, 80–81, 817, 82, 820, 83, 847–848, 86, 883–888, 89, 890, 90, 90, 90, 900, 903, 906, 908–909, 91–92, 92, 92, 92, 92, 921, 924, 927–929, 93–94, 947–948, 95–96, 961–962, 967, 982–983, 983, 983, 983, 983, 983, 983–984, 988–989, 989, 989, 992–993, 993, 993–994, 997, 997, 999
   config.js77.78%100%0%83.33%35
   dataprocessor.js88.02%77.70%92.86%94.71%132, 132, 132, 135–136, 139, 172, 174–175, 180, 185–186, 197, 207, 213, 221, 225, 233, 236, 250, 263, 270, 277, 283, 307, 310, 329, 333, 339–340, 346, 351, 358, 361, 367, 38, 66–68, 71, 77–80
   dbmanager.js84.13%57.50%85.71%100%108–110, 116, 122–124, 132–134, 29, 33, 56–57, 71, 95–96
   debounce.js100%100%100%100%
   drive.js80.91%72.41%83.64%86.30%136, 160, 197, 208, 214, 232, 263, 268, 278, 292, 300, 302, 310, 317–318, 324–326, 326, 326–327, 331, 338, 338, 338–339, 341, 341, 341, 343–345, 347, 357, 364, 377, 379–380, 380, 380–383, 386–388, 396, 402, 418, 429, 436, 453, 463–466, 480, 483, 490, 496–498, 504, 523, 528–530, 534, 541, 549, 576–578, 582, 600, 634, 639, 639, 639–640, 640, 640–643, 646–647, 660–661, 698, 700, 707, 82–85
   histogram.js85.71%71.43%72.73%96.97%101, 113, 125, 129, 142, 145, 148, 154, 17, 28, 33, 33, 73, 77
   mapmanager.js79.29%65.55%75.76%89.05%102, 106, 106, 106–107, 109–110, 110,

@tzebrowski tzebrowski merged commit 051ba8b into main Jun 27, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant