uv_write fix for MSVC Debug#98
Open
ggmini wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently an assertion triggers when compiling and running this project on MSVC with the Debug build target.
I assume that Microsoft changed something in the compilation process which caused this issue, since the issue doesn't occur when compiling with make and a couple of months ago I could still compile Debug on MSVC.
This is a workaround that fixes the issue, with little to no performance impact.
The fix is only applied to Debug Targets on MSVC.
To be fair there is little reason to use this target, aside from debugging, as it is much slower than Release (not the fault of the workaround, I tested it on the Release Target and it showed similar performance to the current Binary on the Releases Page).