Skip to content

Google Adk cookbook#331

Open
CoderOMaster wants to merge 4 commits into
mainfrom
adk-cookbook
Open

Google Adk cookbook#331
CoderOMaster wants to merge 4 commits into
mainfrom
adk-cookbook

Conversation

@CoderOMaster

Copy link
Copy Markdown
Contributor

Pull Request Checklist

Please ensure that your PR meets the following requirements:

  • I have read the CONTRIBUTING guide.
  • I have updated the documentation (if applicable).
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

Description

Google adk cookbook to use with Moss as retrieval tool

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown

Codex review

The new Google ADK cookbook is small and mostly follows existing Moss patterns, but the runnable demo never creates the demo index it defines. Fresh users following the README will fail before retrieval works.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new cookbook under examples/cookbook/google-adk/ demonstrating how to use Moss semantic search as a retrieval tool in a Google Agent Development Kit (ADK) agent, with a runnable onboarding-assistant demo and setup docs. Also registers the new cookbook in AGENTS.md so it appears in the repo’s integration/cookbook index.

Changes:

  • Added a Google ADK + Moss cookbook README with setup, usage, and demo instructions.
  • Added a runnable Python demo (moss_adk.py) implementing an ADK tool factory (create_moss_search_tool) plus an onboarding assistant example.
  • Added cookbook packaging metadata (pyproject.toml), .env.example, and updated AGENTS.md to include the new cookbook entry.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
examples/cookbook/google-adk/README.md Documentation for installing, configuring, running the demo, and integrating the tool into an ADK agent.
examples/cookbook/google-adk/pyproject.toml Declares cookbook dependencies and build settings for distributing the example as a small Python project.
examples/cookbook/google-adk/moss_adk.py Implements the Moss-backed ADK tool factory and the onboarding assistant runnable demo.
examples/cookbook/google-adk/.env.example Template for required environment variables (Moss + OpenAI).
AGENTS.md Adds the new google-adk/ cookbook entry to the integrations list.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread examples/cookbook/google-adk/moss_adk.py Outdated
Comment thread examples/cookbook/google-adk/moss_adk.py Outdated
Comment thread examples/cookbook/google-adk/README.md
CoderOMaster and others added 2 commits July 1, 2026 23:03
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
raise RuntimeError("Missing MOSS_PROJECT_ID or MOSS_PROJECT_KEY environment variables.")
client = MossClient(project_id, project_key)

search = create_moss_search_tool(client, INDEX_NAME)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BLOCKING The demo defines ensure_demo_index() but never calls it, so a fresh project following python moss_adk.py will create the tool and then fail on the first tool call when load_index("onboarding-handbook") tries to load an index that does not exist.

client = MossClient(project_id, project_key)

search = create_moss_search_tool(client, INDEX_NAME)

Call the seeding helper before constructing/running the tool:

client = MossClient(project_id, project_key)
await ensure_demo_index(client, INDEX_NAME)
search = create_moss_search_tool(client, INDEX_NAME)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants