Google Adk cookbook#331
Conversation
6e54c93 to
6c2b2c8
Compare
6c2b2c8 to
96899a5
Compare
Codex reviewThe new Google ADK cookbook is small and mostly follows existing Moss patterns, but the runnable demo never creates the demo index it defines. Fresh users following the README will fail before retrieval works. |
There was a problem hiding this comment.
Pull request overview
Adds a new cookbook under examples/cookbook/google-adk/ demonstrating how to use Moss semantic search as a retrieval tool in a Google Agent Development Kit (ADK) agent, with a runnable onboarding-assistant demo and setup docs. Also registers the new cookbook in AGENTS.md so it appears in the repo’s integration/cookbook index.
Changes:
- Added a Google ADK + Moss cookbook README with setup, usage, and demo instructions.
- Added a runnable Python demo (
moss_adk.py) implementing an ADK tool factory (create_moss_search_tool) plus an onboarding assistant example. - Added cookbook packaging metadata (
pyproject.toml),.env.example, and updatedAGENTS.mdto include the new cookbook entry.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| examples/cookbook/google-adk/README.md | Documentation for installing, configuring, running the demo, and integrating the tool into an ADK agent. |
| examples/cookbook/google-adk/pyproject.toml | Declares cookbook dependencies and build settings for distributing the example as a small Python project. |
| examples/cookbook/google-adk/moss_adk.py | Implements the Moss-backed ADK tool factory and the onboarding assistant runnable demo. |
| examples/cookbook/google-adk/.env.example | Template for required environment variables (Moss + OpenAI). |
| AGENTS.md | Adds the new google-adk/ cookbook entry to the integrations list. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
| raise RuntimeError("Missing MOSS_PROJECT_ID or MOSS_PROJECT_KEY environment variables.") | ||
| client = MossClient(project_id, project_key) | ||
|
|
||
| search = create_moss_search_tool(client, INDEX_NAME) |
There was a problem hiding this comment.
BLOCKING The demo defines ensure_demo_index() but never calls it, so a fresh project following python moss_adk.py will create the tool and then fail on the first tool call when load_index("onboarding-handbook") tries to load an index that does not exist.
client = MossClient(project_id, project_key)
search = create_moss_search_tool(client, INDEX_NAME)Call the seeding helper before constructing/running the tool:
client = MossClient(project_id, project_key)
await ensure_demo_index(client, INDEX_NAME)
search = create_moss_search_tool(client, INDEX_NAME)
Pull Request Checklist
Please ensure that your PR meets the following requirements:
Description
Google adk cookbook to use with Moss as retrieval tool
Type of Change