Skip to content

fix[frontend](socai): added default template for empty previous socai…#2095

Merged
osmontero merged 4 commits into
release/v11.2.9from
backlog/fix/socai
May 22, 2026
Merged

fix[frontend](socai): added default template for empty previous socai…#2095
osmontero merged 4 commits into
release/v11.2.9from
backlog/fix/socai

Conversation

@AlexSanchez-bit
Copy link
Copy Markdown
Contributor

Main chages

previously an already defined configuratio was needed for getting config kays, data types, now a default template for newly created data is setted up so updates can work even if there's no module group on database

@AlexSanchez-bit AlexSanchez-bit requested a review from a team May 21, 2026 21:50
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 21, 2026

❌ Go dependencies check failed

There are outdated Go dependencies, or modules that could not be inspected.
Run bash .github/scripts/go-deps.sh --update --discover locally and
commit the updated go.mod / go.sum files.

Script output
🔍 Discovered 25 Go projects

📦 Dependencies with updates available:

  📁 ./agent:
     - golang.org/x/sys: v0.44.0 → v0.45.0

�[0;31m❌ Please update dependencies before merging.�[0m

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 21, 2026

🛑 AI review — Engineer review required

This PR touches critical paths or introduces changes the model cannot judge with sufficient confidence. @Kbayero @osmontero please review.

⚠️ architecture (gemini-3-flash-lite) — Tier 2 — changes requested

Summary: UI/Backend logic for handling masked configuration values; minor structural improvement needed for data type consistency.

  • medium backend/src/main/java/com/park/utmstack/domain/application_modules/validators/UtmModuleConfigValidator.java:52 — Manual collection of stream results into an ArrayList followed by manual iteration for filtering logic is verbose. Consider using a custom collector or a cleaner stream pipeline to maintain consistency with existing codebase patterns.
  • low frontend/src/app/app-module/guides/guide-soc-ai/guide-soc-ai.component.ts:495 — The pushChange method now accepts a confDataType parameter, but the default value 'text' might lead to silent misconfigurations if new keys are added without explicit types. Ensure this is documented or enforced via a stricter interface.

⚠️ bugs (gemini-3-flash-lite) — Tier 2 — changes requested

Summary: Fixed logic for handling masked API keys and headers; added missing configuration creation logic in pushChange.

  • medium frontend/src/app/app-module/guides/guide-soc-ai/guide-soc-ai.component.ts:58 — The variable 'maskedDisplay' is set to '', but the regex in 'isMaskedValue' (line 595) and the logic in 'loadConfig' (line 392) expect '**' (5 asterisks). This mismatch will cause the UI to fail to recognize masked values correctly.

🛑 security (gemini-3-flash-lite) — Tier 3 — engineer review required

Summary: Modifications to configuration handling and API key persistence logic in SOC AI module.

  • medium backend/src/main/java/com/park/utmstack/domain/application_modules/validators/UtmModuleConfigValidator.java:55 — The validator now allows arbitrary configuration keys to be added to the database if they are not present in the existing configuration. This could lead to configuration injection or unauthorized state modification if input is not strictly sanitized.
  • medium frontend/src/app/app-module/guides/guide-soc-ai/guide-soc-ai.component.ts:505 — The pushChange method now allows creating new configuration entries with arbitrary keys and values if they don't exist, potentially bypassing intended configuration schemas.

Copy link
Copy Markdown

@utmstackprapprover utmstackprapprover Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes requested — see approver comments above.

Copy link
Copy Markdown

@utmstackprapprover utmstackprapprover Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes requested — see approver comments above.

Copy link
Copy Markdown

@utmstackprapprover utmstackprapprover Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes requested — see approver comments above.

@osmontero osmontero merged commit 6e169dd into release/v11.2.9 May 22, 2026
5 of 7 checks passed
@osmontero osmontero deleted the backlog/fix/socai branch May 22, 2026 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants