build findutils for wasm#725
Draft
sylvestre wants to merge 2 commits into
Draft
Conversation
The platform-specific code was split into cfg(unix)/cfg(windows) arms, so wasm32 targets (which are neither) failed to compile. Widen the generic Windows stubs to cfg(not(unix)) and make the -ls printer and xargs size limiters fall back to portable APIs when no platform-specific one exists.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #725 +/- ##
==========================================
+ Coverage 91.83% 91.86% +0.02%
==========================================
Files 35 35
Lines 7129 7155 +26
Branches 375 375
==========================================
+ Hits 6547 6573 +26
Misses 437 437
Partials 145 145 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Add a job that installs the wasm32-wasip1 target plus the WASI SDK (so the bundled C in onig_sys can be cross-compiled) and runs cargo build and clippy -D warnings, so non-Unix compilation can't regress.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.