Get imperative to work on vault on ocp 4.22#124
Merged
Conversation
In Kubernetes 1.35 (which OCP 4.22 is based on), a new security feature was introduced: synthetic RBAC CREATE authorization checks for WebSocket upgrade requests (like pods/exec, pods/attach, pods/portforward). Previously, exec went over SPDY and only required get/connect permissions — your wildcard get/list/watch ClusterRole worked fine. Starting in 1.35, the API server enforces an additional create verb check on pods/exec whenever a WebSocket upgrade happens. This is to close a privilege escalation path where read-only users could exec into pods via the GET-to-WebSocket upgrade. This way we conditionally allow the imperative namespace to exec into the vault namespace. Tested on 4.22 and 4.21
Contributor
|
/lgtm |
Contributor
Author
|
Tested on 4.18 as well, merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Kubernetes 1.35 (which OCP 4.22 is based on), a new security feature
was introduced: synthetic RBAC CREATE authorization checks for WebSocket
upgrade requests (like pods/exec, pods/attach, pods/portforward).
Previously, exec went over SPDY and only required get/connect
permissions — your wildcard get/list/watch ClusterRole worked fine.
Starting in 1.35, the API server enforces an additional create verb
check on pods/exec whenever a WebSocket upgrade happens. This is to
close a privilege escalation path where read-only users could exec into
pods via the GET-to-WebSocket upgrade.
This way we conditionally allow the imperative namespace to exec into the
vault namespace.
Tested on 4.22 and 4.21