fix deprecated warning with DelByName. lock is already taken#10
Open
heitbaum wants to merge 1 commit into
Open
fix deprecated warning with DelByName. lock is already taken#10heitbaum wants to merge 1 commit into
heitbaum wants to merge 1 commit into
Conversation
Member
|
I had a look at how VDR handles recording deletion: |
After Delete() renames the file to .del, remove the recording from the
active Recordings list and add it to DeletedRecordings using explicit
locking, matching VDR's own pattern in svdrp.c.
fixes:
connectionVTP.c: In member function 'bool cConnectionVTP::CmdDELR(const char*)':
connectionVTP.c:2036:70: warning: 'void cRecordings::DelByName(const char*)' is deprecated: use explicit locking, deleting etc. [-Wdeprecated-declarations]
2036 | Recordings->DelByName(recording->FileName());
| ~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~
In file included from /var/media/DATA/home-rudi/LibreELEC.tv/build.LibreELEC-Generic.x86_64-13.0-devel/build/vdr-2.8.1/skins.h:18,
from /var/media/DATA/home-rudi/LibreELEC.tv/build.LibreELEC-Generic.x86_64-13.0-devel/build/vdr-2.8.1/osdbase.h:15,
from /var/media/DATA/home-rudi/LibreELEC.tv/build.LibreELEC-Generic.x86_64-13.0-devel/build/vdr-2.8.1/menuitems.h:15,
from /var/media/DATA/home-rudi/LibreELEC.tv/build.LibreELEC-Generic.x86_64-13.0-devel/build/vdr-2.8.1/plugin.h:14,
from ../common.h:15,
from ../server/connection.h:9,
from ../server/connectionVTP.h:4,
from connectionVTP.c:5:
/var/media/DATA/home-rudi/LibreELEC.tv/build.LibreELEC-Generic.x86_64-13.0-devel/build/vdr-2.8.1/recording.h:314:62: note: declared here
314 | [[deprecated("use explicit locking, deleting etc.")]] void DelByName(const char *FileName);
|
Signed-off-by: Rudi Heitbaum <rudi@heitbaum.com>
Contributor
Author
updated to match vdr. thanks for the feedback |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: