[vercel-flags-core] fix datafile serialization#416
Merged
dferber90 merged 1 commit intoJun 26, 2026
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
vincent-derks
approved these changes
Jun 26, 2026
dferber90
deleted the
dominikferber/fla-3006-fallback-data-not-shown-in-vercel-site
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
Small, localized change to caching in evaluate.ts with the same memoization semantics and no API surface changes.
Overview
Fixes datafiles failing to cross the React Server Components boundary when passed from server to client components.
Evaluation used to cache scaled split weights and compiled regexes by attaching symbol-keyed properties on objects inside the datafile. That stayed hidden from
JSON.stringify, but RSC’s serializer walks objects directly and breaks on non-serializable values (especiallyRegExp).Memoization now lives in module-level
WeakMaps keyed by the same outcome / regex rhs objects, so datafile payloads stay unmodified while cache lifetime and behavior stay equivalent.Reviewed by Cursor Bugbot for commit 94629d9. Bugbot is set up for automated code reviews on this repo. Configure here.