Expose libvcell.__version__ for downstream consumers#18
Open
jcschaff wants to merge 1 commit into
Open
Conversation
Adds libvcell.__version__ resolved from installed package metadata via importlib.metadata, with a 0.0.0 fallback when running from an uninstalled source tree. Helps third-party projects (e.g. pyvcell) that read the version programmatically. py.typed is already shipped, so the package is fully typed for downstream mypy --strict users. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
libvcell.__version__so third-party projects (e.g. pyvcell and its upstream users) can read the installed version programmatically.importlib.metadata.version(single-sourced frompyproject.toml, no duplication)."0.0.0"only when running from an uninstalled source tree (PackageNotFoundError).Typing note
py.typedis already present and shipped in the wheels (verified in the published0.0.15.4artifact + its RECORD), so libvcell is already fully typed for downstreammypy --strictconsumers. This PR is the remaining piece of that "make libvcell friendly to typed downstreams" work.Verification
import libvcellworks without the native lib loaded (lazy-loaded on first call).mypy --strictpasses on the changed module.🤖 Generated with Claude Code